Skip to content

fix: PDTable re-renders after a fetch so RefreshAsync shows the new rows (#241) - #242

Merged
danielabbatt merged 2 commits into
mainfrom
claude/github-issue-241-372e75
Oct 14, 2026
Merged

danielabbatt merged 2 commits into
mainfrom
claude/github-issue-241-372e75

Conversation

@danielabbatt

Copy link
Copy Markdown
Contributor

Fixes #241.

EndFetchAsync now calls StateHasChanged() after ItemsToDisplay is set. This covers RefreshAsync, PageAsync and sorting. Before this change, a refresh started from outside the table (for example, a parent calling _table.RefreshAsync() after a delete) updated the pager count but left the old rows on screen.

Tests: PDTableRefreshRenderTests adds two tests: one refreshes from outside with no selection, the other refreshes after deleting the selected row. Both fail without the fix and pass with it. Full suite: 3799/3799 pass.

@codacy-production

codacy-production Bot commented Oct 14, 2026 •

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 9 complexity · 3 duplication

Metric Results
Complexity 9
Duplication 3

View in Codacy

🟢 Coverage ∅ diff coverage · +0.00% coverage variation

Metric Results
Coverage variation ✅ +0.00% coverage variation
Diff coverage ✅ ∅ diff coverage

View coverage diff in Codacy

Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (260c580) 16054 16031 99.86%
Head commit (e2a745e) 16054 (+0) 16031 (+0) 99.86% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#242) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

AI Reviewer: run a review on demand. To trigger the first review automatically, go to your organization or repository integration settings. AI can make mistakes. Always validate suggestions.

Run reviewer

TIP This summary will be updated as you push new changes.

@danielabbatt
danielabbatt merged commit 8f35684 into main Oct 14, 2026
8 checks passed
@danielabbatt
danielabbatt deleted the claude/github-issue-241-372e75 branch October 14, 2026 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PDTable: RefreshAsync loads new rows but does not re-render them

1 participant