Skip to content

Fix the values of the SHA-224/384/512 HMAC key types - #373

Open
Princemachiavelli wants to merge 1 commit into
parallaxsecond:mainfrom
Princemachiavelli:jhoffer/fix_sha_hmac_typo
Open

Princemachiavelli wants to merge 1 commit into
parallaxsecond:mainfrom
Princemachiavelli:jhoffer/fix_sha_hmac_typo

Conversation

@Princemachiavelli

Copy link
Copy Markdown

KeyType::SHA224_HMAC, SHA384_HMAC and SHA512_HMAC were defined as CKK_SHA256_HMAC, so keys of these types could not be created and a CKA_KEY_TYPE read from a token came back as CKK_SHA256_HMAC. Use the matching CKK_* values.

KeyType::SHA224_HMAC, SHA384_HMAC and SHA512_HMAC were defined as
CKK_SHA256_HMAC, so keys of these types could not be created and a
CKA_KEY_TYPE read from a token came back as CKK_SHA256_HMAC. Use the
matching CKK_* values.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Josh Hoffer <jhoffer@sansorgan.es>

@wiktor-k wiktor-k left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ugh, how did that happen?! 😅

Thanks! 👍

@Jakuje Jakuje left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

obviously correct. The CI failures do not look related. I will investigate them separately

@Jakuje

Jakuje commented Nov 12, 2026

Copy link
Copy Markdown
Collaborator

Looks like the kryoptic failure is actually kryoptic regression in latchset/kryoptic@c0134a2 which allows only the hash-size for the HMAC-SHA-X keys, which is not correct. I will report it

@Jakuje

Jakuje commented Nov 12, 2026

Copy link
Copy Markdown
Collaborator

Filled latchset/kryoptic#581

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants