Skip to content

ui: fallback to Unspecified health status on unexpected enum values #6421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
voidstackloop wants to merge 1 commit into
base: main
Choose a base branch
from
Open

ui: fallback to Unspecified health status on unexpected enum values #6421

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions ui/packages/app/web/src/components/Targets/utils.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,4 +30,19 @@ describe('getHealthStatus', () => {
colorVariant: 'danger',
});
});

it('falls back to Unspecified for out-of-range or invalid numeric values', () => {
expect(getHealthStatus(3)).toEqual({
label: 'Unspecified',
colorVariant: 'neutral',
});
expect(getHealthStatus(-1)).toEqual({
label: 'Unspecified',
colorVariant: 'neutral',
});
expect(getHealthStatus(NaN)).toEqual({
label: 'Unspecified',
colorVariant: 'neutral',
});
});
});
5 changes: 3 additions & 2 deletions ui/packages/app/web/src/components/Targets/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,9 @@ const HealthStatus = {

type HealthStatusType = (typeof HealthStatus)[keyof typeof HealthStatus];

export const getHealthStatus = (numericValue: number) => {
const label = Object.values(HealthStatus)[numericValue];
export const getHealthStatus = (numericValue: number): {label: HealthStatusType; colorVariant: PillVariant} => {
const values = Object.values(HealthStatus);
const label: HealthStatusType = values[numericValue] ?? HealthStatus.Unspecified;

const colorVariants: Record<HealthStatusType, PillVariant> = {
Unspecified: 'neutral',
Expand Down