Repository navigation
chore: bump prettier to 3.9.6 to match the parcelLab/ci lint - #453
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues block the change aligning local formatting with CI.
No open issues 🎉
What changed in this PR
Aligns local Prettier formatting with the shared CI YAML lint configuration, preventing the pre-commit hook from reverting CI-required formatting.
Changes:
- Pins Prettier to 3.9.6 and updates the lockfile.
- Reformats empty maps and lists in four chart values files without changing their parsed values.
| File | Description |
|---|---|
parcellab/worker-group/values.yaml |
Places empty maps inline with their keys. |
parcellab/monolith/values.yaml |
Places empty maps and lists inline with their keys. |
parcellab/microservice/values.yaml |
Places empty maps and lists inline with their keys. |
parcellab/cronjob/values.yaml |
Places empty maps inline with their keys. |
package.json |
Pins Prettier to 3.9.6 to match CI. |
package-lock.json |
Updates the locked Prettier version and package metadata. |
Review effort: Balanced
kpplis
approved these changes
Nov 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lint / yaml(parcelLab/ciyaml.yaml@v9, which pins Prettier 3.9.6) fails onmainfor fourvalues.yamlfiles. The repo's own Prettier (3.5.3, run by the lint-staged pre-commit hook) formats them differently, so they couldn't be fixed locally: the hook reverted the change. Found on #452, where the YAML lint ran for the first time since August.Description
prettierdevDependency 3.5.3 → 3.9.6 (exact, same asparcelLab/ci).parcellab/{cronjob,microservice,monolith,worker-group}/values.yamlreformatted: an empty map now stays on the key's line (externalSecret: {}), with the commented example below it. Whitespace only; the parsed values are identical.Release impact
None.
release.yamlruns its chart tests on merge, and chart-releaser usesCR_SKIP_EXISTING: true, so no chart versions change or get republished.Testing
npx prettier --check "**/*.{yaml,yml}"passes with 3.9.6.