Skip to content

chore: bump prettier to 3.9.6 to match the parcelLab/ci lint - #453

Merged
andibeuge merged 1 commit into
mainfrom
chore-prettier-3.9.6
Nov 5, 2026
Merged

andibeuge merged 1 commit into
mainfrom
chore-prettier-3.9.6

Conversation

@andibeuge

Copy link
Copy Markdown
Contributor

Summary

lint / yaml (parcelLab/ci yaml.yaml@v9, which pins Prettier 3.9.6) fails on main for four values.yaml files. The repo's own Prettier (3.5.3, run by the lint-staged pre-commit hook) formats them differently, so they couldn't be fixed locally: the hook reverted the change. Found on #452, where the YAML lint ran for the first time since August.

Description

  • prettier devDependency 3.5.3 → 3.9.6 (exact, same as parcelLab/ci).
  • parcellab/{cronjob,microservice,monolith,worker-group}/values.yaml reformatted: an empty map now stays on the key's line (externalSecret: {}), with the commented example below it. Whitespace only; the parsed values are identical.

Release impact

None. release.yaml runs its chart tests on merge, and chart-releaser uses CR_SKIP_EXISTING: true, so no chart versions change or get republished.

Testing

npx prettier --check "**/*.{yaml,yml}" passes with 3.9.6.

@andibeuge
andibeuge requested review from a team as code owners November 5, 2026 14:13
Copilot AI balanced review requested due to automatic review settings November 5, 2026 14:13
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 5, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-05T14:15:21.740441Z 3409849 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues block the change aligning local formatting with CI.

No open issues 🎉

What changed in this PR

Aligns local Prettier formatting with the shared CI YAML lint configuration, preventing the pre-commit hook from reverting CI-required formatting.

Changes:

  • Pins Prettier to 3.9.6 and updates the lockfile.
  • Reformats empty maps and lists in four chart values files without changing their parsed values.
File Description
parcellab/​worker-group/​values.yaml Places empty maps inline with their keys.
parcellab/​monolith/​values.yaml Places empty maps and lists inline with their keys.
parcellab/​microservice/​values.yaml Places empty maps and lists inline with their keys.
parcellab/​cronjob/​values.yaml Places empty maps inline with their keys.
package.json Pins Prettier to 3.9.6 to match CI.
package-lock.json Updates the locked Prettier version and package metadata.

Review effort: Balanced

@andibeuge
andibeuge merged commit 1d4689b into main Nov 5, 2026
5 checks passed
@andibeuge
andibeuge deleted the chore-prettier-3.9.6 branch November 5, 2026 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants