Skip to content

feat(preview): pass an optional npm read token to preview image builds #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
armonge merged 1 commit into from
Oct 29, 2026
Merged

feat(preview): pass an optional npm read token to preview image builds #157

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .github/workflows/preview.build-image.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,10 @@ on:
description: Maximum minutes before the job is cancelled
default: 40
type: number
secrets:
npmGithubReadToken:
required: false
description: The Github token with permissions to read NPM private packages, available to the build as the npm_github_token secret
jobs:
build-and-push-image-to-ecr:
permissions:
Expand Down Expand Up @@ -83,6 +87,8 @@ jobs:
platforms: linux/amd64
provenance: false
push: true
secrets: |
npm_github_token=${{ secrets.npmGithubReadToken }}
# preview-<PR>-<sha> is what the preview appsets deploy; closing the PR deletes all of them
tags: |
${{ steps.login-ecr.outputs.registry }}/${{ inputs.APPLICATION_NAME }}:preview-${{ github.event.pull_request.number }}
Expand Down
Loading