Skip to content

fix(deps): resolve postcss-selector-parser vulnerability - #45

Merged
Akarda merged 4 commits into
mainfrom
fix/postcss-selector-parser-vuln
Oct 20, 2026
Merged

Akarda merged 4 commits into
mainfrom
fix/postcss-selector-parser-vuln

Conversation

@armonge

@armonge armonge commented Oct 14, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Add postcss-selector-parser: ^7.1.6 to overrides (6.1.4 → 7.1.6), fixing GHSA-rj75-hqrm-r3gf and clearing all 12 moderate audit findings (cssnano / postcss-calc / vue-loader chain).
  • Includes the Dependabot shell-quote 1.10.0 → 1.12.0 bump (supersedes that PR).

Not fixed

braces (GHSA-vfj7-8cjw-p6xm, high) affects all versions; 3.0.3 is the latest, so there is no patch yet. Only reached via dev/build tooling (@vue/cli-service, webpack-dev-server), not shipped in v3//v5/. npm audit fix --force would downgrade @vue/cli-service to 3.3.1, so don't use it.

Test plan

  • npm test: 44/44 passing
  • npm run build succeeds

dependabot Bot and others added 2 commits October 13, 2026 21:35
Bumps [shell-quote](https://github.com/ljharb/shell-quote) from 1.10.0 to 1.12.0.
- [Changelog](https://github.com/ljharb/shell-quote/blob/main/CHANGELOG.md)
- [Commits](ljharb/shell-quote@v1.10.0...v1.12.0)

---
updated-dependencies:
- dependency-name: shell-quote
  dependency-version: 1.12.0
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Resolves GHSA-rj75-hqrm-r3gf (moderate) across the cssnano / vue-loader chain.
braces (GHSA-vfj7-8cjw-p6xm) remains: no patched release exists yet.
@armonge
armonge requested a review from a team as a code owner October 14, 2026 07:12

@Akarda Akarda left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed and verified locally after merging current main (no conflicts):

  • npm ci + npm test: 44/44 pass. Build drift check: committed v3//v5/ match npm run build.
  • Fixes Dependabot alerts #148 (postcss-selector-parser 7.1.6), and via the lockfile refresh also #149 (@vue/server-renderer 3.5.44) and #150 (proxy-addr 2.0.8).
  • Rebuilt Vue bundles (webpack 5.111): ran the v3/v5 Vue test suites against the built index.js instead of index.vue — 13/13 pass, same as main. Same exports (name, props, render, created) and same min ES level (ES2017).
  • Real app check: Vite + Vue 3 app installing main vs this PR from npm pack tarballs. Production build OK. In the browser, v3 and v5 both load the live CDN plugin, call initialize with the options, and render identically. No console errors.
  • npm pack contents unchanged (11 files); v5/web/index.js (CDN deploy) untouched.

@Akarda
Akarda merged commit cbad8ed into main Oct 20, 2026
1 check passed
@Akarda
Akarda deleted the fix/postcss-selector-parser-vuln branch October 20, 2026 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants