Repository navigation
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Superseded by consolidated postal geocoding PR #124. This PR's head commit is retained in the combined branch. Combined CI passes on Node.js 24/26 and static checks.
Summary
Support approximate delivery-to-return location analysis for Canada with current, documented FSA data. Correct compact and lowercase full-code lookup.
Refresh from GeoNames CA.zip, retrieved 2026-11-04 (export timestamp 2026-11-04), under CC BY 4.0. Credit: GeoNames. Source has 1,657 rows; output has 1,650 unique FSAs across all 13 provinces and territories. This does not establish complete national coverage. Source observations have no known dataset date.
Deduplicate coordinate pairs before taking their arithmetic mean for repeated FSAs. These are representative source points, not postal-area centroids. Exclude the H0H North Pole point and two full-code anomalies. Full postal inputs still resolve at FSA precision. Preserve string coordinate pairs, exports, allowlists and other-country behavior. Details, primary-source checks, exclusions, archive hash and generation command are in
docs/geocode-CAN.md.Evidence
undefinedforK1A0A6andk1a 0a6.After: both return
['-75.7023', '45.4207'].npm run lint,npm run format:check,npm run validate:datapass. Data validation retains two existing AUT/BEL warnings. The CAN generator's assertions pass and regeneration is reproducible.Merge Danger
Door: two-way
Blast Radius: CAN
FSA points can give large errors in rural and northern Canada. Two distant postal codes in one FSA produce zero distance. X0A's source point is not Iqaluit's location. No full-code positional accuracy is claimed. H0H and legacy L0V now return
undefined; malformed full codes are rejected. No production use or exhaustive ground-truth check was performed.Shared-file overlap with other country PRs: the small CAN-only branch in
lib/geocode.js. No other-country data, generic refactor, new dependency, merge or deployment.