Skip to content

chore: bump cfg_aliases, async-trait, eyre and fix darling lint for Rust 1.99 clippy - #2296

Open
playX18 wants to merge 2 commits into
masterfrom
ap-bump-cfg_aliases
Open

playX18 wants to merge 2 commits into
masterfrom
ap-bump-cfg_aliases

Conversation

@playX18

@playX18 playX18 commented Oct 27, 2026 •

Copy link
Copy Markdown
Member

Rust 1.99 made clippy stricter, and CI fails on lints triggered by macro-generated code:

  • cfg_aliases 0.2.1 to 0.2.2: trailing semicolon in macro (semicolon_in_expressions_from_non_local_macros)
  • eyre 0.6.12 to 0.6.14: same lint, from bail!
  • async-trait 0.1.88 to 0.1.92: double_must_use on #[async_trait] methods
  • macro: #[darling(multiple, default)] on 3 fields to avoid redundant_field_names
    in darling's generated code (no behaviour change: the expanded code differs only in
    the field initializer, still an empty Vec when the attribute is absent)

This also unblocks #2267 (Update Artifacts), which refreshes the lightclient chainspec
checkpoint behind #2263.

@playX18
playX18 requested a review from DenzelPenzel October 27, 2026 02:23
@playX18 playX18 self-assigned this Oct 27, 2026
@socket-security

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updatedcargo/​cfg_aliases@​0.2.1 ⏵ 0.2.210010093100100
Addedcargo/​syn@​3.0.9100100100100100

View full report

@playX18 playX18 changed the title chore: bump cfg_aliases in integration-tests chore: bump cfg_aliases, async-trait, eyre and fix darling lint for Rust 1.99 clippy Oct 27, 2026
@DenzelPenzel
DenzelPenzel requested a review from lexnv October 27, 2026 10:19

@DenzelPenzel DenzelPenzel left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants