Skip to content

Use the new app icons on macOS - #340

Merged
patchzyy merged 1 commit into
patchzyy:mainfrom
DarthMDev:macos-app-icons
Oct 24, 2026
Merged

patchzyy merged 1 commit into
patchzyy:mainfrom
DarthMDev:macos-app-icons

Conversation

@DarthMDev

@DarthMDev DarthMDev commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

Converted the WiiCompiled and Retro Rewind Windows icons to .icns and include them in the macOS app bundles. Each app’s Info.plist now points to its matching icon.
Verified packaging and signing, then translated, compiled, and launched Retro Rewind on macOS to confirm the icon appears correctly.
image

Summary by CodeRabbit

  • New Features
    • The macOS app bundle now includes the product icon, allowing it to appear consistently in places where the app is shown, such as the Dock and Finder.

@coderabbitai

coderabbitai Bot commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: bc73d833-d7be-449b-b8b7-75f0aaa059e0
📥 Commits

Reviewing files that changed from the base of the PR and between ac99413 and 159c11c.

📒 Files selected for processing: 3
  • Launcher/macos/publish-app.command
  • runtime/resources/RetroRewind.icns
  • runtime/resources/WiiCompiled.icns

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.

📝 Walkthrough

The macOS publish script now locates the product’s .icns file, fails if it is missing, records its filename in Info.plist, and copies it into the app bundle’s Resources directory.

Changes: macOS App Icon

Layer / File(s) Summary
Locate and bundle the product icon
Launcher/macos/publish-app.command
The script resolves the product icon relative to its own directory and fails if the file is missing. It sets CFBundleIconFile in Info.plist and copies the icon into the app bundle’s Resources directory.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~5 minutes

Change: Feature

Merge Risk: ⚪ Minimal · up to 159c1

No actionable merge-blocking risk was identified in the macOS icon bundling changes.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title "Use the new app icons on macOS" matches the main change. The PR adds .icns icon files for the macOS app bundles and wires them into Info.plist and Contents/Resources. The title is specific …
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title "Use the new app icons on macOS" matches the main change. The PR adds .icns icon files for the macOS app bundles and wires them into Info.plist and Contents/Resources. The title is specific and concise, and it states the platform and the purpose of the change. The file summary covers only the publish script, which is a narrower view than the PR objectives, but the title still fits the primary change.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@patchzyy
patchzyy merged commit 0aba3cb into patchzyy:main Oct 24, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants