Skip to content

Start the theme transition at the toggle button #336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
milanofthe merged 1 commit into from
Sep 14, 2026
Merged

Start the theme transition at the toggle button #336

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/lib/utils/themeTransition.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,11 +28,16 @@ export function toggleThemeWithTransition(e?: MouseEvent, fallbackOrigin?: HTMLE
return;
}

// The circle is given in percent of the snapshot box, not in pixels: browsers may size the
// snapshot in device pixels (e.g. on high-density displays with GPU rendering), which would
// put a pixel-based center at the wrong place. Percent radii refer to the box diagonal / sqrt(2).
const maxRadius = Math.hypot(Math.max(x, innerWidth - x), Math.max(y, innerHeight - y));
const center = `${(x / innerWidth) * 100}% ${(y / innerHeight) * 100}%`;
const radius = (maxRadius / (Math.hypot(innerWidth, innerHeight) / Math.SQRT2)) * 100;
const transition = document.startViewTransition(apply);
transition.ready.then(() => {
document.documentElement.animate(
{ clipPath: [`circle(0px at ${x}px ${y}px)`, `circle(${maxRadius}px at ${x}px ${y}px)`] },
{ clipPath: [`circle(0% at ${center})`, `circle(${radius}% at ${center})`] },
{ duration: 500, easing: 'ease-out', pseudoElement: '::view-transition-new(root)' }
);
});
Expand Down