Repository navigation
Conversation
51999c9 gave FrequencyPickerContent its own verticalScroll on the premise that FT8AFBottomSheet didn't scroll, but the sheet has wrapped its content in verticalScroll since the Compose UI landed. The nested scroll is measured with an infinite max height and Compose throws IllegalStateException as soon as the picker opens. Drop the inner scroll; the sheet's scroll already keeps the alternates reachable on short screens. The #930 layout test rendered the picker body on its own, so it never saw the nesting. Host it in FT8AFBottomSheet as the app does, and add a regression test that opens FrequencyPickerSheet itself. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- Pin OperationBand.bandList, GeneralVariables.operatingMode and excludedBands in a @Before/@after fixture instead of a one-off try/finally, so the picker tests don't depend on what an earlier Robolectric test left in the shared statics. - Expand the alternates in the portrait open test and scroll to the last chip, so the sheet-owned scroll is checked in portrait as well as landscape. - Document the scroll contract on FT8AFBottomSheet: content must not add its own vertical scroll, which is how #972 happened. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Fix crash opening "All bands & custom frequency" (#972)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## staging #974 +/- ##
=============================================
+ Coverage 42.42% 42.47% +0.05%
Complexity 309 309
=============================================
Files 283 283
Lines 34909 34908 -1
Branches 4219 4219
=============================================
+ Hits 14809 14827 +18
+ Misses 19771 19746 -25
- Partials 329 335 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Debug APKDownload FT8AF-pr974-6787f49-debug.zip (built from 6787f49, run) Unzip it and install the Uninstalling deletes all of the app data: the QSO log, settings, and saved logbook and rig configuration. Export your log as ADIF before you do this on a phone you operate from. |
Promotes everything merged into
devsince the last staging promotion (#967): 1 PR, 3 commits.Bands / UI
FT8AFBottomSheetnow documents the no-nested-scroll contract.🤖 Generated with Claude Code