Repository navigation
fix: support backtick member escapes in JSONPath Plus - #10
Merged
Merged
Conversation
daveshanley
marked this pull request as ready for review
October 24, 2026 13:55
Member
Author
|
@greptileai review Please review the backtick member-selection change at 6f28853. All CI checks pass, including Linux, Windows, macOS, and the full compliance suite. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JSONPath Plus selectors such as
$.schema.`$refcurrently fail to compile. This adds single-prefix backtick escapes for literal member selection in dot, recursive, and unquoted bracket notation, using the existing name-selector evaluator.A trailing backtick remains part of the key. Strict RFC mode still rejects the extension, quoted keys retain literal backticks, and filters continue to use quoted bracket notation. Normalized paths use quoted brackets.
Related: daveshanley/vacuum#1004. Vacuum integration: daveshanley/vacuum#1012 (pins this exact commit).
Validation: full Go suite including the RFC compliance submodule; focused race tests; regressions fail against the base parser; new scanner has 100% statement coverage. Independent correctness and de-slop reviews found no material issues.
Risk: medium because parsing is shared by callers. The extension is enabled by default and disabled in strict RFC mode. Focused boundary and normalization tests cover the new syntax; evaluation is unchanged.