Repository navigation
feat(receipt): TASK-24141 record which receipt action users tap - #3897
Merged
Merged
Conversation
Share receipt (the link) became the primary on every receipt and Split this bill moved to More actions (#3896). Neither tap was measured: autocapture is off in production, and the only proxy was requests with a prefilled split comment, about 1 in 100 eligible receipts. One event, receipt_action_tapped with action, placement and kind, now records every tap on share link, share PDF, download PDF and split, in the drawer and on the QR success screen, so the primary can be judged on data in four weeks. ShareButton takes an onClick that runs on the tap, before the share, because a share sheet the user closes still says they wanted to share.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Author
|
/chip review |
Contributor
Code-analysis diffPainscore total: 10582.78 → 10585.3 (+2.52) 🆕 New findings (15)
✅ Resolved (14)
📈 Painscore deltas (top movers)
|
![chip-peanut-bot[bot]](https://avatars.githubusercontent.com/in/2915219?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Chip review — no blocking findings — this is not an approval
No findings.
Checked clean
- Confirmed the detached worktree head and exact dev merge base; reviewed the full eight-file diff.
- Checked receipt-action placement and kind against rendered primary, overflow, and QR-success controls, including disabled actions and the single-navigation guard.
- Checked ShareButton tap callback ordering against the share hook and its failure-path test; existing share behavior remains intact.
- Checked the analytics capture configuration and design rulebook; the added event carries only action, placement, and wire kind.
- At review time, typecheck, eslint, format, ds-lint, screen tests, and provenance checks passed; unit and several unrelated jobs were still in progress.
Security review: did not run — this change has no security, privacy or money surface, so it was not asked. This review is one reviewer short.
Third opinion by claude-opus: 0 finding(s), marked with the model name. It answers only product truth, missing tests and the cross-repo contract, so treat its findings as advice.
Copy check by claude-haiku-5-5: 0 finding(s), titled "Copy now wrong". Every quoted passage was checked against the file.
Exact head: 43362ec20807 · Context: repo, design, lexicon · Took 5m
Contributor
🧪 UI test report — ✅ all greenSuites
📊 Coverage (unit)
⏱ 10 slowest test cases
|
abalinda
marked this pull request as ready for review
October 31, 2026 09:41
abalinda
requested review from
0xkkonrad,
Hugo0,
innolope-dev,
jjramirezn and
kushagrasarathe
as code owners
October 31, 2026 09:41
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#3896 made Share receipt (the link) the primary on every receipt and moved Split this bill to More actions. Neither tap was measured: autocapture is off in production, and the only proxy for Split was requests created with the prefilled "Bill split for …" comment, about 1 in 100 eligible QR and card receipts, by roughly 10 people a week. This PR records every tap so the primary can be judged on data in four weeks.
One event,
receipt_action_tapped, with three properties:actionshare_link,share_pdf,download_pdf,splitplacementprimary,more_actions,qr_successkindDIRECT_TRANSFER,QR_PAY,CARD_SPEND_CLEAR, …)The tap is recorded, not its outcome: a share sheet the user closes still says they wanted to share.
ShareButtongets anonClickthat runs on the tap, before the share starts, for that reason.Task: TASK-24141 Share receipt links for every transaction type. Follow-ups of the receipt work: TASK-24263.
Where it fires
ReceiptActions.tsx: the link primary, the Split primary, the PDF share primary, and the More actions rows Split, Share receipt (PDF), Download receipt (PDF).QrPaySuccessView.tsx: Split this bill on the QR payment success screen (placement: qr_success), once per screen even on a double tap.receipt-action-analytics.tsholds the onetrackReceiptActionhelper and its two types.Risks
Tests
ReceiptActions.receipt-routing.test.tsx: one event per control, with the expected action, placement and kind, in the drawer's four shapes.QrPaySuccessView.test.tsx: the success-screen Split records one tap, also on a double tap.ShareButton.test.tsx:onClickruns on the tap, before the share, also when the share then fails.Reading the data
In PostHog, a trends insight on
receipt_action_tappedbroken down byaction, filtered byplacement, answers "share link vs split" per week; addkindto compare QR and card receipts with the rest.Screenshots: N/A (no visible change)
🤖 Generated with Claude Code