Repository navigation
Fix unused method warning and run Clippy on cargo-hax in CI - #2352
Open
zac-scheiwe wants to merge 1 commit into
Open
zac-scheiwe wants to merge 1 commit into
zac-scheiwe wants to merge 1 commit into
Conversation
Fixes pereq-dev#2265 - `ToolVersions::iter` (cli/cargo-hax/src/tools/manifest.rs) is only used by tests, so gate it behind `#[cfg(test)]` instead of removing it. - Add a CI step in .github/workflows/clippy_rust_engine.yml running `cargo clippy -p cargo-hax --no-deps --all-targets -- -D warnings`. - Fix the existing Clippy lints in cargo-hax so that step passes (no behaviour change).
maximebuyse
self-requested a review
October 27, 2026 08:43
maximebuyse
requested changes
Oct 27, 2026
maximebuyse
left a comment
maximebuyse
left a comment
Contributor
There was a problem hiding this comment.
Thanks for taking care of this! I added a suggested change to cover more in the clippy invocation added to the CI. With this addition the PR will be good to merge.
| cargo clippy -p hax-rust-engine -- -D warnings --no-deps | ||
| - name: Run clippy on cargo-hax | ||
| run: | | ||
| cargo clippy -p cargo-hax --no-deps --all-targets -- -D warnings |
Contributor
There was a problem hiding this comment.
Suggested change
| cargo clippy -p cargo-hax --no-deps --all-targets -- -D warnings | |
| cargo clippy -p cargo-hax --no-deps --all-targets --all-features -- -D warnings |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2265
ToolVersions::iter(cli/cargo-hax/src/tools/manifest.rs) is only used by tests, so gate it behind#[cfg(test)]instead of removing it.cargo clippy -p cargo-hax --no-deps --all-targets -- -D warnings.