Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PtyProcess.spawn accepts a list or tuple, but slicing a tuple leaves it immutable. Replacing argv[0] with the resolved executable then raises TypeError before the child starts. Copy the accepted arguments to a list without changing the caller's input.
The regressions run real Python children through both PtyProcess and PtyProcessUnicode, checking PATH resolution, arguments with spaces, output, exit status and unchanged list/tuple inputs.
Validation on Python 3.14.7/macOS arm64:
python -m pytest --timeout 60 -v: 19 passed, none skipped.python -m compileall -q ptyprocess tests/test_spawn.pyandgit diff --checkpass.Other Python versions and platforms were not tested.