Skip to content

Fix the transitive JavaScript dependency vulnerabilities in /web. - #10729

Closed
dpage wants to merge 1 commit into
pgadmin-org:masterfrom
dpage:fix-transitive-vulns
Closed

dpage wants to merge 1 commit into
pgadmin-org:masterfrom
dpage:fix-transitive-vulns

Conversation

@dpage

@dpage dpage commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Clears the open Dependabot alerts for indirect dependencies in web/yarn.lock that have a fix within the ranges their dependents already accept, by raising the floors in resolutions:

  • brace-expansion 2.0.3 → 2.1.7 and 5.0.7 → 5.0.12 (7 alerts, 5 high)
  • svgo 3.3.3 → 3.3.5 (3 alerts, 2 high)
  • ip-address 10.7.2 → 10.7.5
  • @babel/core 7.29.0 deduplicated onto 7.29.7

Left alone, deliberately:

  • minimatch (GHSA-g3hv-75wg-m249, moderate): the only fix is 11.0.1, which rewrites the matcher, whilst every dependent here asks for 3.x, 5.x, 9.x or 10.x. The only users are eslint, typescript-eslint, eslint-plugin-react and filelist, which never see untrusted patterns, so I'd rather wait for them to move than force a major.
  • deepmerge and paramiko: no fixed release exists.
  • undici (runtime): already resolves to the patched 7.30.1, so the alert should close on rescan.

Summary by CodeRabbit

  • Chores
    • Updated version selections for several underlying software components, including address handling, text processing, and graphics optimization.
    • These updates affect the software’s underlying package configuration; no user-facing feature or behavior changes are specified in this update.

Raise the resolution floors so that the indirect dependencies flagged by
Dependabot resolve to their patched releases, all within the ranges their
dependents already accept:

- brace-expansion 2.x to 2.1.7 and 5.x to 5.0.12
- svgo to 3.3.5 (via @svgr/plugin-svgo)
- ip-address to 10.7.5

The older @babel/core 7.29.0 entry is deduplicated onto 7.29.7, which the
project already depends on directly.

minimatch is deliberately left alone: the only fixed release is 11.0.1,
which rewrites the matcher, whilst everything here depends on 3.x, 5.x,
9.x or 10.x, and only build and lint tooling, which is never given
untrusted patterns, uses it. deepmerge has no fixed release.
@coderabbitai

coderabbitai Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The frontend package manifest updates the ip-address resolution, adds two brace-expansion resolutions, updates another brace-expansion resolution, and adds an svgo resolution.

Changes

Frontend dependency resolutions

Layer / File(s) Summary
Update frontend dependency resolutions
web/package.json
Updates the ip-address and brace-expansion resolutions, and adds resolutions for two brace-expansion ranges and svgo.

Estimated code review effort: 1 (Trivial) | ~4 minutes

Change: Other

Possibly related PRs

Suggested reviewers: asheshv

Merge Risk: Minimal · up to 6e28a

The dependency updates introduce no identified runtime, build, security, or deployment regression and are mergeable with normal checks.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly describes the main change: updating transitive JavaScript dependency resolutions in /web to address vulnerabilities.
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

Finishing Touches
Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share
Recent review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between dde24b4 and 6e28a2b.

Files ignored due to path filters: 1
  • web/yarn.lock is excluded by !**/yarn.lock, !**/*.lock
Files selected for processing: 1
  • web/package.json

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review.

dpage added a commit that referenced this pull request Nov 4, 2026
)

Raise the resolution floors so that the indirect dependencies flagged by
Dependabot resolve to their patched releases, all within the ranges their
dependents already accept:

- brace-expansion 2.x to 2.1.7 and 5.x to 5.0.12
- svgo to 3.3.5 (via @svgr/plugin-svgo)
- ip-address to 10.7.5

The older @babel/core 7.29.0 entry is deduplicated onto 7.29.7, which the
project already depends on directly.

minimatch is deliberately left alone: the only fixed release is 11.0.1,
which rewrites the matcher, whilst everything here depends on 3.x, 5.x,
9.x or 10.x, and only build and lint tooling, which is never given
untrusted patterns, uses it. deepmerge has no fixed release.
@dpage

dpage commented Nov 4, 2026

Copy link
Copy Markdown
Contributor Author

Landed as dca776e.

@dpage dpage closed this Nov 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant