You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Give the CI workflows a read-only GITHUB_TOKEN. - #10730
The repository's default workflow token permission is write, and twelve of the check and test workflows declare no permissions: of their own, so their jobs get a write token they never use. This adds a top-level permissions: contents: read to each, matching acceptance-test.yml and snapshot.yml, and clears the 12 CodeQL actions/missing-workflow-permissions alerts.
None of the affected jobs use the token beyond actions/checkout and actions/upload-artifact. I've checked that this merges cleanly with #10727 in either order, and its new check-epas-secrets job is fine with read-only permissions.
Summary by CodeRabbit
Chores
Automated build, style, translation, and test workflows now have read-only access to repository contents.
The repository's default workflow token permission is write, and these
twelve workflows set no permissions of their own, so every job was handed
a token able to write to the repository. None of them use it for anything
beyond checking out the code and uploading artefacts, so restrict the
token to contents: read, matching the workflows that already declare it.
This clears the CodeQL actions/missing-workflow-permissions alerts.
No actionable comments were generated in the recent review.
Walkthrough
Twelve GitHub Actions workflows now declare contents: read permissions. The changes cover documentation, style, build, translation, and test workflows.
pgadmin-org/pgadmin4#10727: It changes some of the same CI workflows, so the permissions added here also apply to jobs changed or added by that PR.
Suggested reviewers: asheshv
Merge Risk: Minimal · up to 8c040
The workflows retain the required checkout and artifact behavior while removing unnecessary token permissions.
Pre-merge checks: 5
Check name
Status
Explanation
Description Check
Check skipped - CodeRabbit’s high-level summary is enabled.
Title check
The title "Give the CI workflows a read-only GITHUB_TOKEN." matches the main change. The raw summary shows that all twelve workflow files gain a three-line top-level permissions block that limits the …
Docstring Coverage
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Title check
Explanation
The title "Give the CI workflows a read-only GITHUB_TOKEN." matches the main change. The raw summary shows that all twelve workflow files gain a three-line top-level permissions block that limits the token to contents: read. The PR objectives state the same purpose: the twelve workflows do not need write access, and the change limits their tokens accordingly. The title is specific and concise, and it does not mention any file list or vague wording.
Full details: Docstring Coverage
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (12 skipped: 12 unsupported.)
Finishing Touches
Generate unit tests (beta)
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 6 remain after this review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The repository's default workflow token permission is write, and twelve of the check and test workflows declare no
permissions:of their own, so their jobs get a write token they never use. This adds a top-levelpermissions: contents: readto each, matchingacceptance-test.ymlandsnapshot.yml, and clears the 12 CodeQLactions/missing-workflow-permissionsalerts.None of the affected jobs use the token beyond
actions/checkoutandactions/upload-artifact. I've checked that this merges cleanly with #10727 in either order, and its newcheck-epas-secretsjob is fine with read-only permissions.Summary by CodeRabbit