You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Fix an overly large character range in the named query regex. - #10732
Fixes CodeQL alert 41 (py/overly-large-range): named_query_regex in sqlcompletion.py used [A-z0-9\-], and A-z also matches [ \ ] ^ _ ` .
The class is now [A-Za-z0-9_\-]. The underscore is kept on purpose, since pgcli (which this code comes from) now lists it explicitly in the same regex, so names like my_query still get stripped.
Summary by CodeRabbit
Bug Fixes
Saved-query names containing uppercase letters are now recognized by SQL autocomplete.
named_query_regex, used to strip a leading '\ns <name>' from the text
passed to the autocompleter, matched names with [A-z0-9\-]. The A-z range
also covers the characters [ \ ] ^ _ and `, which CodeQL flags as
py/overly-large-range. Spell the class out as [A-Za-z0-9_\-] instead,
keeping the underscore deliberately since pgcli, from which this code is
derived, now lists it explicitly in the same regex.
Check skipped - CodeRabbit’s high-level summary is enabled.
Title check
The title names the regex change, but the changeset does more than fix a character range. It also keeps the underscore in the regex and makes the regex accept uppercase letters. The title states the m…
Docstring Coverage
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Title check
Explanation
The title names the regex change, but the changeset does more than fix a character range. It also keeps the underscore in the regex and makes the regex accept uppercase letters. The title states the main change, which is a narrowed and corrected character range in named_query_regex. It is specific and accurate, so it passes.
Full details: Docstring Coverage
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 1 files.
Finishing Touches
Generate unit tests (beta)
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 4 remain after this review.
This branch has not been deployed
No deployments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes CodeQL alert 41 (
py/overly-large-range):named_query_regexinsqlcompletion.pyused[A-z0-9\-], andA-zalso matches[ \ ] ^ _ `.The class is now
[A-Za-z0-9_\-]. The underscore is kept on purpose, since pgcli (which this code comes from) now lists it explicitly in the same regex, so names likemy_querystill get stripped.Summary by CodeRabbit