[msun4100]

Summary

• Fixes Dark theme shows a white main panel after closing all tabs (regression in 9.19) #10736, a regression of Dark Theme starts with a big white screen #7481 after the rc-dock 4.1.0 upgrade in 9.19.
• rc-dock 4.1.0 renders the tab body as .dock-body-holder > .dock-body and only creates .dock-content per tab. The Dark Theme starts with a big white screen #7481 fix on .dock-content no longer covers a panel with no tabs, so rc-dock's default .dock-panel { background: #fff } shows through.
• Paint .dock-panel itself with theme.palette.background.default, so an empty panel follows the theme regardless of the tab body markup.

Verified

• On the 9.19 desktop build (macOS), the white area in an empty main panel resolves to .dock-panel with rgb(255, 255, 255) (see Dark theme shows a white main panel after closing all tabs (regression in 9.19) #10736).

How to test

1. Set the theme to Dark.
2. Open Query Tool tabs in the main panel, then Close All → the main panel uses the theme background.
3. Restart with a saved layout whose main panel has no tabs → no white panel.
4. Light and high contrast themes: an empty main panel uses the theme background.
5. Object Explorer, Query Tool, PSQL and Schema Diff workspaces and floating dialog panels look unchanged.

Summary by CodeRabbit

• Style
  • Dock panels now use the theme’s default background color.

[coderabbitai]

No actionable comments were generated in the recent review.

Walkthrough

The .dock-panel override now sets its background color to the theme’s default background.

Changes

Dock panel theme background

Layer / File(s)	Summary
Set dock panel background web/pgadmin/static/js/Theme/overrides/rcdock.override.js	The .dock-panel background now uses theme.palette.background.default.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Bug fix · Severity of issue fixed: Low

Merge Risk: Minimal · up to 28d69

The theme background fix is appropriately scoped and introduces no identified merge-blocking risk.

Pre-merge checks: 5

Check name	Status	Explanation
Description Check		Check skipped - CodeRabbit’s high-level summary is enabled.
Title check		The title names the reported symptom (dark theme showing a white main panel after closing all tabs) and references issue #10736. The changeset is a one-line CSS override that sets the .dock-panel back…
Linked Issues check		Issue #10736 requires an empty main panel to use the theme background after all tabs close and on startup with no saved tabs. The reviewed file sets .dock-panel backgroundColor to `theme.palette.b…
Out of Scope Changes check		The supplied whole-PR summary identifies one change in web/pgadmin/static/js/Theme/overrides/rcdock.override.js. The change paints dock panels with the theme background. This directly supports issue…
Docstring Coverage		No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…

Full details: Title check

Explanation

The title names the reported symptom (dark theme showing a white main panel after closing all tabs) and references issue #10736. The changeset is a one-line CSS override that sets the .dock-panel background to the theme default background, which addresses that symptom. The title describes the bug rather than the fix, but it is specific and tied to the actual change, so it is a pass.

Full details: Linked Issues check

Explanation

Issue #10736 requires an empty main panel to use the theme background after all tabs close and on startup with no saved tabs. The reviewed file sets .dock-panel backgroundColor to theme.palette.background.default. This selector covers the empty panel described by the issue and does not depend on per-tab .dock-content elements. The issue does not specify an automated-test requirement.

Full details: Out of Scope Changes check

Explanation

The supplied whole-PR summary identifies one change in web/pgadmin/static/js/Theme/overrides/rcdock.override.js. The change paints dock panels with the theme background. This directly supports issue #10736 and does not show unrelated behavior or files.

Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 1 files.

Finishing Touches

Generate unit tests (beta)

• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Tip

🎯 Customize your risk assessments

Guide how CodeRabbit assesses merge risk and security architecture risk. Highlight sensitive changes and explain your security boundaries using Merge Risk Instructions and Security Risk Instructions in your review settings. Security architecture risk assessments require the Advanced plan or above.

✅ Automatic approvals, with your rules

Let CodeRabbit approve pull requests once required threads are resolved, pre-merge checks pass, and your risk limits are met. Enable Automatic approvals in review settings, with overrides for teams or file paths.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

• X
• Mastodon
• Reddit
• LinkedIn

Recent review info

Run configuration

• Source mode: Auto
• Repository: pgadmin-org/pgadmin4
• Branch: master
• File: .coderabbit.yaml
• Commit: dca776e
• Layers: Repository YAML
• Review profile: CHILL
• Plan: Advanced
• Run ID: 5485ee9b-64ad-4207-81ae-6f3b76271463

Commits

Reviewing files that changed from the base of the PR and between dca776e and 28d69e1.

Files selected for processing: 1

• web/pgadmin/static/js/Theme/overrides/rcdock.override.js

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review.

[dpage]

Thanks! Squashed and merged as 5c15032.