Skip to content

CI: use the shared check-structure.php from doc-base - #484

Closed
lacatoire wants to merge 2 commits into
php:masterfrom
lacatoire:translation/shared-check-structure
Closed

CI: use the shared check-structure.php from doc-base#484
lacatoire wants to merge 2 commits into
php:masterfrom
lacatoire:translation/shared-check-structure

Conversation

@lacatoire

Copy link
Copy Markdown
Member

Replaces the local copy of check-structure.php with the shared one from php/doc-base (merged in php/doc-base#342), so that every translation runs the same version.

The workflow now checks out the translation, en and doc-base side by side, the layout the doc-base scripts expect and the one the build workflow already uses.

@KentarouTakeda

Copy link
Copy Markdown
Collaborator

Thanks. The points in #412 (comment) still stand.

Two of them are now in doc-base, so we can't fix them here. A divergence that is only a difference in nesting depth still prints the same signature on both sides. The translator-credits exemption still doesn't match ours, so preface.xml and bookinfo.xml can never pass.

Closing. Happy to revisit once those land upstream and the check looks at changed hunks rather than whole files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants