Skip to content

feat(API): add owner_id parameter to job template create and update endpoints - #1287

Merged
Sven Dunemann (forelabs) merged 1 commit into
mainfrom
openapi-sync/strings-app-pr-18797
Sep 23, 2026
Merged

Sven Dunemann (forelabs) merged 1 commit into
mainfrom
openapi-sync/strings-app-pr-18797

Conversation

@phrase-bot

Copy link
Copy Markdown
Collaborator

This PR was generated by the openapi-apply agent in response to a
/openapi-sync apply request on
Phrase-Engineering/strings-app#18797.

What changed in the API

  • POST /api/v2/accounts/{account_id}/job_templates and PATCH /api/v2/accounts/{account_id}/job_templates/{id} now accept an optional owner_id string (the account member's public code) in the request body; passing a blank value clears a previously set owner.
  • POST /api/v2/projects/{project_id}/job_templates and PATCH /api/v2/projects/{project_id}/job_templates/{id} accept the same owner_id parameter, but additionally validates that the referenced user is a member of the project (not just the account); non-members yield a 404.

Source

Notes for reviewers

  • The proposal's fragment comments suggested file paths paths/job_templates/create.yaml (for account-level) and paths/project_job_templates/create.yaml (for project-level). The actual repo uses paths/organization_job_templates/ for account-level templates and paths/job_templates/ for project-level templates. The agent applied changes to the correct existing files.
  • make lint passed (exit code 0). The java: not found warning from openapi-generator-cli during lint.sh is a pre-existing environment limitation in the CI runner, not caused by these changes; the step reported "No validation errors" despite the warning.

Opened automatically by the openapi-apply agent. Review the spec changes
against the linked strings-app PR; the agent does not vouch for correctness
beyond "the YAML parsed and the documented layout was followed."

@github-actions

Copy link
Copy Markdown
Contributor

API changelog (oasdiff)

Doc-only edits (descriptions, examples) do not appear here.

4 changes: 0 error, 0 warning, 4 info
info	[new-optional-request-property] at doc/compiled.json
	in API POST /accounts/{account_id}/job_templates
		added the new optional request property `owner_id`

info	[new-optional-request-property] at doc/compiled.json
	in API PATCH /accounts/{account_id}/job_templates/{id}
		added the new optional request property `owner_id`

info	[new-optional-request-property] at doc/compiled.json
	in API POST /projects/{project_id}/job_templates
		added the new optional request property `owner_id`

info	[new-optional-request-property] at doc/compiled.json
	in API PATCH /projects/{project_id}/job_templates/{id}
		added the new optional request property `owner_id`

@forelabs
Sven Dunemann (forelabs) merged commit 8dd71f9 into main Sep 23, 2026
13 checks passed
@forelabs
Sven Dunemann (forelabs) deleted the openapi-sync/strings-app-pr-18797 branch September 23, 2026 12:09
@forelabs Sven Dunemann (forelabs) changed the title feat(API): add owner_id parameter to job template create and update endpoints #STRINGS-3477 feat(API): add owner_id parameter to job template create and update endpoints Sep 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants