Repository navigation
feat(API): add owner_id parameter to job template create and update endpoints - #1287
Merged
Merged
Conversation
…ndpoints #STRINGS-3477
Contributor
API changelog (oasdiff)Doc-only edits (descriptions, examples) do not appear here. |
Sven Dunemann (forelabs)
approved these changes
Sep 23, 2026
Sven Dunemann (forelabs)
deleted the
openapi-sync/strings-app-pr-18797
branch
September 23, 2026 12:09
This was referenced Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was generated by the
openapi-applyagent in response to a/openapi-sync applyrequest onPhrase-Engineering/strings-app#18797.
What changed in the API
POST /api/v2/accounts/{account_id}/job_templatesandPATCH /api/v2/accounts/{account_id}/job_templates/{id}now accept an optionalowner_idstring (the account member's publiccode) in the request body; passing a blank value clears a previously set owner.POST /api/v2/projects/{project_id}/job_templatesandPATCH /api/v2/projects/{project_id}/job_templates/{id}accept the sameowner_idparameter, but additionally validates that the referenced user is a member of the project (not just the account); non-members yield a404.Source
Notes for reviewers
paths/job_templates/create.yaml(for account-level) andpaths/project_job_templates/create.yaml(for project-level). The actual repo usespaths/organization_job_templates/for account-level templates andpaths/job_templates/for project-level templates. The agent applied changes to the correct existing files.make lintpassed (exit code 0). Thejava: not foundwarning fromopenapi-generator-cliduringlint.shis a pre-existing environment limitation in the CI runner, not caused by these changes; the step reported "No validation errors" despite the warning.Opened automatically by the
openapi-applyagent. Review the spec changesagainst the linked strings-app PR; the agent does not vouch for correctness
beyond "the YAML parsed and the documented layout was followed."