Repository navigation
fix(cli): bump release build GOVERSION to 1.27.1 - #1292
Merged
Merged
Conversation
clients/cli/build/config.sh defaulted GOVERSION to 1.24, which build.sh uses to pick the golang:$GOVERSION Docker image for the release cross-compile step. Since clients/cli/go.mod now requires go >= 1.27.1, releases were failing in phrase-cli CI with: go: go.mod requires go >= 1.27.1 (running go 1.24.13; GOTOOLCHAIN=local) This file is rsynced verbatim into phrase-cli by the build-cli job in .github/workflows/build.yml, so the fix belongs here, not in that repo. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Contributor
API changelog (oasdiff)Doc-only edits (descriptions, examples) do not appear here. |
Sönke Behrendt (theSoenke)
approved these changes
Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
clients/cli/build/config.shdefaultedGOVERSIONto1.24;build.shuses it to pick thegolang:$GOVERSIONDocker image for the release cross-compile stepclients/cli/go.modto requirego >= 1.27.1,phrase-clirelease runs started failing: https://github.com/phrase/phrase-cli/actions/runs/35861991189/job/107184185129clients/cli/build/is rsynced verbatim intophrase/phrase-cliby thebuild-clijob in.github/workflows/build.yml(not generated from an openapi-generator template), so the fix belongs in this repoTest plan
clients/cli/build/isn't produced by anyopenapi-generator/templates/cli/*template or theMakefile'sclitarget — it's a plain tracked file synced via rsyncphrase-clipicks upgolang:1.27.1and succeeds🤖 Generated with Claude Code