Repository navigation
feat(API): add page/per_page params to repo_syncs list endpoint #STRINGS-3518 - #1297
Merged
Merged
Conversation
GET /accounts/{account_id}/repo_syncs is paginated server-side via
Kaminari (default_per_page = 25), but the spec's parameters list was
missing the reusable page/per_page $refs already used by 50+ other
list endpoints, even though the Link and Pagination response headers
were already declared. Consumers of the spec had no signal that this
endpoint returns only a page of results.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Contributor
API changelog (oasdiff)Doc-only edits (descriptions, examples) do not appear here. |
Sven Dunemann (forelabs)
requested review from
Sven Dunemann (forelabs)
and removed request for
Stephen Lumenta (sbl)
September 24, 2026 07:19
Sven Dunemann (forelabs)
approved these changes
Sep 24, 2026
This was referenced Sep 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GET /accounts/{account_id}/repo_syncsis paginated server-side via Kaminari (default_per_page = 25in strings-app), returning its true total via aPaginationresponse header plus a standardLink: rel="next"header — both already declared in this endpoint's spec.parameterslist inpaths/repo_syncs/index.yamlonly documentedX-PhraseApp-OTPandaccount_id, omitting the reusablepage/per_page$refs already used by 50+ other list endpoints (e.g.paths/accounts/index.yaml,paths/accounts/locales.yaml,paths/authorizations/index.yaml).$ref: parameters.yaml#/pageand$ref: parameters.yaml#/per_pagetopaths/repo_syncs/index.yaml, consistent with sibling paginated list endpoints, and regenerateddoc/compiled.jsonto reflect the new parameters.Test plan
npx swagger-cli validate main.yaml— passesnpx swagger-cli bundle -t json -w 300 main.yaml > doc/compiled.json— regenerated, diff only adds the two new parameter refs to therepo_syncslist operationbash ./lint.sh(viaopenapi-generator-cli validateagainst the bundled spec) — no validation errorsSTRINGS-3518
🤖 Generated with Claude Code