Repository navigation
fix(cli): add testify to Go template to stop build-cli failures - #1311
Merged
Merged
Conversation
The go Makefile target runs `cd clients/go && go mod tidy` after generating phrase-go. Since clients/go/test/ contains committed test files that import testify, tidy adds testify v1.12.1 to go.mod. The verification build then compares the CLI's go.mod (testify v1.9.0) against the local phrase-go (testify v1.12.1) and fails with "go: updates to go.mod needed". Fix: - Add testify v1.12.1 and go.yaml.in/yaml/v3 v3.0.5 to go.mod.mustache so that `go mod tidy` in clients/go is a no-op for testify - Update the template go.sum with testify v1.12.1 and go.yaml.in checksums - Bump testify in clients/cli/go.mod from v1.9.0 to v1.12.1 so the verification build's module graph is already satisfied - Run `go mod tidy` to update clients/cli/go.sum Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Franca Winter (francawinter)
force-pushed
the
claude/fix-cli-go-sum
branch
from
October 5, 2026 09:22
969ca59 to
79c1ded
Compare
Contributor
API changelog (oasdiff)Doc-only edits (descriptions, examples) do not appear here. |
…tive Go 1.21+ normalizes two-part go directives (go 1.23) to three-part (go 1.23.0) when running go mod tidy, causing a persistent diff in the generated phrase-go go.mod on every CI run. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Franca Winter (francawinter)
marked this pull request as ready for review
October 5, 2026 09:35
jablan
approved these changes
Oct 5, 2026
Contributor
|
🤞 |
This was referenced Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
goMakefile target runscd clients/go && go mod tidyafter generating phrase-go; sinceclients/go/test/has committed test files that import testify, tidy addstestify v1.12.1to go.modtestify v1.9.0) against the local phrase-go (testify v1.12.1) and fails withgo: updates to go.mod neededtestify v1.12.1andgo.yaml.in/yaml/v3 v3.0.5togo.mod.mustacheso that tidy is a no-op for testify after generationclients/cli/go.modfrom v1.9.0 to v1.12.1 and updates go.sum accordinglySteps to verify
build-clijob should pass🤖 Generated with Claude Code