Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review. 📝 WalkthroughWalkthroughChangesPartitioned table guidance
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~2 minutes Change: Other Merge Risk: ⚪ Minimal · up to The documentation accurately clarifies the supported partition operations without changing runtime behavior. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
…ed tables Hash and Key partitioned tables do not support DROP PARTITION at all, so framing this as "these partitions are rarely truncated" misstates the limitation as a matter of frequency rather than a hard unsupported-operation constraint. Reworded to state the trade-off does not apply to these tables, rather than implying dropping is just uncommon. Found while reviewing the Japanese translation of this file, which faithfully mirrored this EN wording; flagged by a CodeRabbit review on the JA translation PR. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
44345a6 to
3fe9938
Compare
What is changed, added or deleted? (Required)
best-practices/tidb-partitioned-tables-best-practices.mdsaid:This is self-contradictory: Hash and Key partitioned tables don't support `DROP PARTITION` at all (a hard constraint), so framing it as "these partitions are rarely truncated" misstates a total lack of support as a matter of low frequency. Reworded to state that the DROP-PARTITION performance trade-off simply doesn't apply to these tables, since the operation isn't available on them.
Found while reviewing the Japanese translation of this file (which faithfully mirrored this EN wording) — flagged by a CodeRabbit review on the JA PR.
Which TiDB version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?
AI agent involvement
Do your changes match any of the following descriptions?
🤖 Generated with Claude Code
Summary by CodeRabbit