Repository navigation
fix(android): form sheets sit beside a vertical hinge in landscape book posture (t3.50) - #11
Merged
Merged
Conversation
Wide inner displays such as the Galaxy Z Fold 8 report book posture as landscape, so the portrait-only check kept their sheets centered across the hinge. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
|
juliusmarminge
added a commit
to pingdotgg/t3code
that referenced
this pull request
Nov 13, 2026
Book-posture sheet placement only ran in portrait, and wide inner displays such as the Galaxy Z Fold 8 report book posture as landscape. Screens 5.0.0-t3.50 (pingdotgg/react-native-screens#11) drops the orientation check. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Android form sheets moved beside a vertical hinge only when the window was portrait. Wide inner displays, such as the Galaxy Z Fold 8 (2448×1848) and the original Pixel Fold (2208×1840), report book posture as landscape, so their sheets stayed centered across the crease.
A vertical folding feature already means book posture, so
FormSheetPlacementno longer takes an orientation. The landscape case is now inFormSheetPlacementTest(4/4 pass, run through the t3code app's Gradle build).This branch also carries t3.48's three Android sheet commits from PixPMusic (
c49845fd4,2f7d46113,6ce484b34), which shipped in pingdotgg/t3code#18492 and were never ont3/main. The release commit pointspack-t3at this repository.Released as
5.0.0-t3.50(tagt3-v5.0.0-t3.50, brancht3/release-t3.50), vendored by pingdotgg/t3code#34207. Merge together with that PR.🤖 Generated with Claude Code
Note
Place form sheets beside a vertical hinge in Android book posture
FormSheetPostureObserver, which tracks vertical folding features and hinge angle (with hysteresis) on Android R+, andFormSheetPlacement, which resolves sheet width, left margin, and gravity from the available segmentFormSheetPlacement.resolveandsetupBottomSheetHeightfor edge cases around invalid hinge positions (at zero, at, or beyond the window width)Macroscope summarized ffc98c6.