Skip to content

fix(android): form sheets sit beside a vertical hinge in landscape book posture (t3.50) - #11

Merged
juliusmarminge merged 5 commits into
t3/mainfrom
t3/fold-landscape-book
Nov 13, 2026
Merged

juliusmarminge merged 5 commits into
t3/mainfrom
t3/fold-landscape-book

Conversation

@juliusmarminge

@juliusmarminge juliusmarminge commented Nov 13, 2026 •

Copy link
Copy Markdown
Member

Android form sheets moved beside a vertical hinge only when the window was portrait. Wide inner displays, such as the Galaxy Z Fold 8 (2448×1848) and the original Pixel Fold (2208×1840), report book posture as landscape, so their sheets stayed centered across the crease.

A vertical folding feature already means book posture, so FormSheetPlacement no longer takes an orientation. The landscape case is now in FormSheetPlacementTest (4/4 pass, run through the t3code app's Gradle build).

This branch also carries t3.48's three Android sheet commits from PixPMusic (c49845fd4, 2f7d46113, 6ce484b34), which shipped in pingdotgg/t3code#18492 and were never on t3/main. The release commit points pack-t3 at this repository.

Released as 5.0.0-t3.50 (tag t3-v5.0.0-t3.50, branch t3/release-t3.50), vendored by pingdotgg/t3code#34207. Merge together with that PR.

🤖 Generated with Claude Code

Note

Place form sheets beside a vertical hinge in Android book posture

  • Form sheets now use the window segment left of a vertical fold instead of spanning the full window, capped at Material's maximum width and anchored to the segment's left edge
  • Adds FormSheetPostureObserver, which tracks vertical folding features and hinge angle (with hysteresis) on Android R+, and FormSheetPlacement, which resolves sheet width, left margin, and gravity from the available segment
  • Both the dialog-based form sheet (FormSheetDialog.kt) and the legacy stack path (ScreensCoordinatorLayout.kt) apply the placement and re-layout when the hinge position changes
  • The legacy coordinator also reports a bottom-sheet layout change when the sheet width changes
  • Risk: sheets now size to the window segment before the hinge on foldable devices; check FormSheetPlacement.resolve and setupBottomSheetHeight for edge cases around invalid hinge positions (at zero, at, or beyond the window width)

Macroscope summarized ffc98c6.

Alex Jankowiak and others added 5 commits October 26, 2026 23:50
Wide inner displays such as the Galaxy Z Fold 8 report book posture as landscape, so
the portrait-only check kept their sheets centered across the hinge.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Nov 13, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Team
  • Run ID: 56bbc67a-9595-44de-8f24-9f3126fcdaa6

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

juliusmarminge added a commit to pingdotgg/t3code that referenced this pull request Nov 13, 2026
Book-posture sheet placement only ran in portrait, and wide inner displays such as
the Galaxy Z Fold 8 report book posture as landscape. Screens 5.0.0-t3.50
(pingdotgg/react-native-screens#11) drops the orientation check.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@juliusmarminge
juliusmarminge merged commit 0ae59e5 into t3/main Nov 13, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant