Skip to content

[Bug]: clone URL rewrite breaks when the HTTPS password contains @ #27846

Closed

Description

@samkelly880

Before submitting

  • I searched existing issues and did not find a duplicate.
  • I included enough detail to reproduce or investigate the problem.

Area

packages/shared

Steps to reproduce

Call cloneUrlForProtocol("https://user:tok@en@github.com/a/b.git", "ssh").

Expected behavior

git@github.com:a/b.git (password may contain @; host is after the last userinfo @).

Actual behavior

git@en@github.com:a/b.git — the regex stopped userinfo at the first @.

Impact

Minor bug or occasional failure

Fix

#27845

Activity

  1. juliusmarminge commented on Nov 9, 2026

    @juliusmarminge
    Member

    Thanks for reporting this! #24005 fixed credential parsing on main in 7a633ce, including passwords containing @.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions