Skip to content

[Bug]: Restore device defaults leaves Auto-settle off after a project is picked on Threads settings #35155

Open

Description

@only21mil

Before submitting

  • I searched existing issues and did not find a duplicate.
  • I included enough detail to reproduce or investigate the problem.

Area

apps/web

Steps to reproduce

On Linux, from a fresh checkout:

  1. git clone https://github.com/pingdotgg/t3code && cd t3code && git checkout 2de337003d && vp i
  2. Make a sample project: mkdir -p /tmp/sample && git -C /tmp/sample init -b main && git -C /tmp/sample -c user.name=Sample -c user.email=sample@example.com commit --allow-empty -m init
  3. Start the app with a new, empty T3 home (so nothing touches an existing install's settings): vp run dev --home-dir "$(mktemp -d /tmp/t3-restore.XXXXXX)" --no-seed. From its output, note baseDir= on the [dev-runner] line and the web address (webPort=).
  4. When that output shows Listening on, in a second shell from the same t3code checkout, add the project: cd apps/server && node src/bin.ts project add --base-dir <baseDir> --title Sample /tmp/sample, then mint a pairing link: node src/bin.ts pair --base-dir <baseDir>.
  5. Open the printed pairing URL in Chromium. If a Welcome page shows, click "Start".
  6. Open /settings/threads. In the "Auto-settle" section, click the switch "Auto-settle inactive threads" so it is off.
  7. At the top, after "Applying settings for", click "All projects" and choose "Sample".
  8. In the settings sidebar, click "General". Click "Restore device defaults" (top right). The dialog says "This will reset: Auto-settle inactive threads, New thread mode." Click "Confirm".
  9. In the settings sidebar, click "Threads". After "Applying settings for", click "Sample" and choose "All projects". Look at the switch "Auto-settle inactive threads". Reload the page and look again.

Expected behavior

"Auto-settle inactive threads" is on again, with 7 in "Days of inactivity before auto-settle".

Actual behavior

"Auto-settle inactive threads" is still off, also after the reload, although the dialog listed it. No message says it was not reset.

Impact

Minor bug or occasional failure

Version or commit

main, commit 2de3370

Environment

Linux, web client in Chromium; the dev server from source with a new, empty T3 home (step 3). No provider needed.

Logs or stack traces

Screenshots, recordings, or supporting files

main 2de3370: the dialog lists Auto-settle inactive threads and New thread mode
main 2de3370: the dialog lists Auto-settle inactive threads and New thread mode

main 2de3370: Auto-settle inactive threads is off on Threads
main 2de3370: Auto-settle inactive threads is off on Threads

Workaround

Turn the setting back on by hand in Settings > Threads.

A fix is in #32729.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions