Skip to content

fix(web): mod+b toggles the sidebar unless composer text is selected #15763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SepehrRajabi wants to merge 2 commits into from
Closed

fix(web): mod+b toggles the sidebar unless composer text is selected #15763

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b279353
fix(web): mod+b toggles the sidebar unless composer text is selected
SepehrRajabi Oct 4, 2026
ea1a1d5
fix(web): only yield mod+b when the selection is inside the composer
SepehrRajabi Oct 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions apps/web/src/components/AppSidebarLayout.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,13 +102,20 @@ function SidebarControl() {
) {
return;
}
const richComposer =
event.target instanceof HTMLElement
? event.target.closest('[data-composer-rich-text="true"]')
: null;
const selection = window.getSelection();
if (
isRichTextBoldShortcut(event) &&
event.target instanceof HTMLElement &&
event.target.closest('[data-composer-rich-text="true"]')
richComposer &&
selection?.isCollapsed === false &&
richComposer.contains(selection.anchorNode) &&
richComposer.contains(selection.focusNode)
) {
// The rich-text composer claims Mod+B for bold; the toggle stays
// available everywhere else, including the plain-text composer.
// The rich-text composer claims Mod+B to bold its selected text. Without a
// selection the toggle wins, since the composer holds focus most of the time.
return;
}
if (
Expand Down
2 changes: 1 addition & 1 deletion apps/web/src/keybindings.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -422,7 +422,7 @@ export function isOpenFavoriteEditorShortcut(
/**
* Whether the keypress is the rich-text bold chord (Mod+B without extra
* modifiers). Tiptap binds the same chord, so app shortcuts captured ahead
* of the editor must yield when the rich-text composer is focused.
* of the editor must yield when the rich-text composer has text selected.
*/
export function isRichTextBoldShortcut(event: ShortcutEventLike): boolean {
if (event.type !== undefined && event.type !== "keydown") {
Expand Down
Loading