Skip to content

fix(client): default follow-up to queue so queued prompts wait #16011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sss-ace-555 wants to merge 1 commit into from
Closed

fix(client): default follow-up to queue so queued prompts wait #16011

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/web/src/components/chat/ComposerPrimaryActions.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ export const ComposerPrimaryActions = memo(function ComposerPrimaryActions({
pendingAction,
isRunning,
canInterrupt,
followUpBehavior = "steer",
followUpBehavior = "queue",
alternateShortcutLabel = null,
showPlanFollowUpPrompt,
promptHasText,
Expand Down
8 changes: 4 additions & 4 deletions packages/client-runtime/src/state/composerDispatch.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,9 @@ describe("resolveComposerDispatchMode", () => {
expect(resolveComposerDispatchMode({ running: false, alternateModifier: false })).toBe("auto");
});

it("steers by default and reserves Mod+Enter for queueing while running", () => {
expect(resolveComposerDispatchMode({ running: true, alternateModifier: false })).toBe("steer");
expect(resolveComposerDispatchMode({ running: true, alternateModifier: true })).toBe("queue");
it("queues by default and reserves Mod+Enter for steering while running", () => {
expect(resolveComposerDispatchMode({ running: true, alternateModifier: false })).toBe("queue");
expect(resolveComposerDispatchMode({ running: true, alternateModifier: true })).toBe("steer");
});

it("queues as the alternate action when restarting is the default", () => {
Expand Down Expand Up @@ -67,6 +67,6 @@ describe("resolveComposerDispatchMode", () => {
it("names the alternate action so the affordance can be labelled", () => {
expect(alternateComposerDispatchAction("queue")).toBe("steer");
expect(alternateComposerDispatchAction("steer")).toBe("queue");
expect(alternateComposerDispatchAction()).toBe("queue");
expect(alternateComposerDispatchAction()).toBe("steer");
});
});
2 changes: 1 addition & 1 deletion packages/client-runtime/src/state/composerDispatch.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ export function resolveComposerDispatchMode(input: {
readonly activeTurnDefault?: ActiveTurnComposerAction;
}): ComposerDispatchMode {
if (!input.running) return "auto";
const defaultAction = input.activeTurnDefault ?? "steer";
const defaultAction = input.activeTurnDefault ?? "queue";
if (input.alternateModifier) return defaultAction === "queue" ? "steer" : "queue";
return defaultAction;
}
Expand Down
Loading