Repository navigation
fix(web): preserve draft edits during attachment preparation #22102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
saphid
wants to merge
10
commits into
pingdotgg:main
from
saphid:fix/attachment-retry-draft-20261020
+255
−2
Closed
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
aa7c510
fix(web): preserve draft edits during attachment preparation
saphid 737415b
fix(web): retain draft edits through the extracted send flows
saphid 6c7f834
Merge commit '50c1c5dc536493826fc66e220598f38b831d5bde' into HEAD
saphid 2c591e4
fix(web): preserve environment mention edits while preparing attachments
saphid ef17dbd
style(web): format environment draft regression
saphid 0a2a261
chore: merge main into attachment draft fix
maria-rcks 98eda86
fix(web): retain drafts with pending attachment preparation
maria-rcks b7fd2c0
chore: merge main into attachment draft fix
maria-rcks 66c2da6
fix(web): recheck the draft after redirect uploads finish
maria-rcks 41e1798
Merge remote-tracking branch 'github/main' into fix/attachment-retry-…
maria-rcks File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use the same pending-work key for both draft routes.
getComposerDraftresolves a thread reference to its draft ID, butcomposerTargetKeydoes not. If a user opens the same draft through its thread URL while an upload waits, new image preparation uses the thread key while this check uses the draft ID. The send can then dispatch the old snapshot before the image is ready. Use a canonical key for both preparation tracking and this check. (raw.githubusercontent.com)