Repository navigation
feat(web): calmer, clearer UI that beats Claude Code and Codex in design review #24837
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -1151,6 +1151,14 @@ export default function GitActionsControl({ | |
| ? (quickAction.hint ?? "This action is currently unavailable.") | ||
| : null; | ||
| const gitActionProgress = resolveGitActionProgressPresentation(vcsActionState); | ||
| // A fresh draft with nothing to commit, push, or diff hides those rows until there is work. | ||
| const quietEmptyDraft = | ||
| isPanel && | ||
| draftId !== undefined && | ||
| gitActionProgress === null && | ||
| quickAction.disabled && | ||
| !changesTotals?.insertions && | ||
| !changesTotals?.deletions; | ||
|
Comment on lines
+1155
to
+1161
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Keep the Git action result visible for a clean draft. When a panel action succeeds and the refreshed Git status has zero insertions and deletions,
|
||
| const pendingDefaultBranchActionCopy = pendingDefaultBranchAction | ||
| ? resolveDefaultBranchActionDialogCopy({ | ||
| action: pendingDefaultBranchAction.action, | ||
|
|
@@ -1684,7 +1692,7 @@ export default function GitActionsControl({ | |
| {initAction.isPending ? "Initializing..." : "Initialize Git"} | ||
| </span> | ||
| </ThreadDetailsControl> | ||
| ) : compact && !gitActionProgress && !visibleInlineSuccess ? null : ( | ||
| ) : quietEmptyDraft || (compact && !gitActionProgress && !visibleInlineSuccess) ? null : ( | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🟡 Medium After a draft action completes with a clean, synchronized status, this condition hides the action group even while 🚀 Reply "fix it for me" or copy this AI Prompt for your agent: |
||
| <ActionGroup | ||
| role="group" | ||
| aria-label="Git actions" | ||
|
|
@@ -1821,7 +1829,7 @@ export default function GitActionsControl({ | |
| </ActionGroup> | ||
| )} | ||
|
|
||
| {isPanel && isRepo ? ( | ||
| {isPanel && isRepo && !quietEmptyDraft ? ( | ||
| <ThreadDetailsControl | ||
| type="button" | ||
| variant="ghost" | ||
|
|
@@ -1832,11 +1840,21 @@ export default function GitActionsControl({ | |
| > | ||
| <FileDiffIcon className={THREAD_DETAILS_PANEL_ICON_CLASS} aria-hidden /> | ||
| <span className={cn("flex-1 text-left", THREAD_DETAILS_PANEL_LABEL_CLASS)}>Changes</span> | ||
| <span className="flex items-center gap-1 font-mono text-2xs tabular-nums"> | ||
| <span className="text-diff-addition"> | ||
| <span className="flex items-center gap-1 font-mono text-xs tabular-nums"> | ||
| <span | ||
| className={ | ||
| changesTotals?.insertions | ||
| ? "text-diff-addition-foreground" | ||
| : "text-muted-foreground" | ||
| } | ||
| > | ||
| +{formatDiffCount(changesTotals?.insertions ?? 0)} | ||
| </span> | ||
| <span className="text-diff-deletion"> | ||
| <span | ||
| className={ | ||
| changesTotals?.deletions ? "text-diff-deletion-foreground" : "text-muted-foreground" | ||
| } | ||
| > | ||
| -{formatDiffCount(changesTotals?.deletions ?? 0)} | ||
| </span> | ||
| </span> | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟠 High
components/GitActionsControl.tsx:1160A draft with only binary changes hides both Git actions and the Changes row, even though Commit is available: binary files have zero insertions and deletions, so
quietEmptyDraftevaluates totruewhen the quick action is disabled on detachedHEAD. Check for changed files rather than nonzero line totals.🚀 Reply "fix it for me" or copy this AI Prompt for your agent: