Skip to content

fix(mobile): the portrait Duo drawer's last rows clear its tab bar - #26140

Closed
jakeleventhal wants to merge 4 commits into
pingdotgg:mainfrom
jakeleventhal:fix/duo-portrait-drawer-tab-clearance
Closed

jakeleventhal wants to merge 4 commits into
pingdotgg:mainfrom
jakeleventhal:fix/duo-portrait-drawer-tab-clearance

Conversation

@jakeleventhal

@jakeleventhal jakeleventhal commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

On an unfolded iPhone Duo in portrait, the sidebar drawer draws its own floating tab bar, but lists in the drawer only reserved the Duo's usual 16pt of bottom clearance. Even scrolled to the bottom, the last Settings row (Archive) stayed behind the tab bar. The Chats and PRs lists use the same clearance. Landscape was fine because the tabs move to the system side rail.

The Duo branch of bottomClearance in WorkspaceRootScreen assumed the column's safe area already covered everything at the bottom. That holds for the search toolbar and keyboard, but not for WorkspaceSidebarTabs, which renders in the portrait drawer exactly when sidebarPicker is true. That case now reserves 80pt, the same value the other iOS sidebar-picker path already uses. Other Duo layouts are unchanged.

Before / after (unfolded iPhone Duo simulator, portrait, Settings drawer scrolled to the bottom):

Before After

Done with Claude Opus 5.5 in Claude Code (running in T3 Code).

🤖 Generated with Claude Code

Fixes #26990

@github-actions github-actions Bot added vouch:trusted Author is trusted by repo permissions or the VOUCHED list. size:XS 0-9 changed lines (additions + deletions). labels Oct 27, 2026
@macroscopeapp

macroscopeapp Bot commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at af57adb

Macroscope's review found this PR approvable — Adds bottom spacing to the iOS Duo sidebar-picker layout so the last drawer rows can clear its tab bar. The change is limited to presentation, with no product-default or persistent-data changes.

No code changes detected at d9f8ac6. Prior analysis still applies.

You can add or adjust custom eligibility rules. Learn more.

@coderabbitai

coderabbitai Bot commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

Run configuration

Commits

Reviewing files that changed from the base of the PR and between d9f8ac6 and c98d180.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review

No actionable comments were generated in the recent review.

Walkthrough

For Duo devices, the workspace root now adds 80 pixels of bottom clearance when the sidebar picker is active and 16 pixels otherwise. The comment clarifies that the column safe area does not hold sidebar tabs.

Changes: Duo workspace clearance

Layer / File(s) Summary
Sidebar picker clearance
apps/mobile/src/features/layout/workspace/WorkspaceRootScreen.tsx
The bottom clearance now depends on sidebarPicker: 80 pixels when active and 16 otherwise.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Possibly related issues

Possibly related PRs

  • pingdotgg/t3code#24206: This PR also changes Duo sidebar tab placement and list bottom-clearance calculations.

Suggested reviewers: juliusmarminge

Merge Risk: Minimal · previous review 9cd16

The change increases bottom clearance for the Duo sidebar picker to address the reported obscured rows. No actionable merge-blocking risk is evident in the supplied context.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title clearly describes the drawer clearance fix.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Description check Passed The description explains the problem and change, links the related issue, and includes before-and-after screenshots from the affected simulator scenario. It does not include an explicit maintainer app…
Full details: Description check

Explanation

The description explains the problem and change, links the related issue, and includes before-and-after screenshots from the affected simulator scenario. It does not include an explicit maintainer approval comment or describe separate test results, but the description is mostly complete.

Finishing Touches

Generate unit tests (beta)

  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Recent review info

Run configuration

Commits

Reviewing files that changed from the base of the PR and between 1cb14bc and 9cd160e.

Files selected for processing: 1

  • apps/mobile/src/features/layout/workspace/WorkspaceRootScreen.tsx

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

@jakeleventhal
jakeleventhal force-pushed the fix/duo-portrait-drawer-tab-clearance branch from af57adb to 1cb14bc Compare October 28, 2026 13:02
@juliusmarminge juliusmarminge added bugfix Fix PR opened by an issue lead; enters the PR loop pr:gate-failed A land gate failed labels Oct 29, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@jakeleventhal
jakeleventhal force-pushed the fix/duo-portrait-drawer-tab-clearance branch from 1cb14bc to 9cd160e Compare November 6, 2026 16:42
juliusmarminge and others added 2 commits November 12, 2026 21:13
@juliusmarminge

Copy link
Copy Markdown
Member

The automated pipeline stopped on this pull request and will not merge it:

the capture step could not show the problem on the base commit, so there is nothing to prove fixed.

On both commits, opened the unfolded Duo app and requested portrait and landscape rotation. The app remained landscape with its side rail. Opened Settings, selected General, and performed five upward sidebar swipes from (180,550) to (180,160). Recorded the interaction and captured Archive fully above the search toolbar. Final still pairs taken more than 500 ms apart were pixel-identical. The requested portrait reproduction could not be executed.

It stays open for a person to finish or close.

@juliusmarminge juliusmarminge added the takeover:in-progress A takeover lead is working on this PR label Nov 13, 2026
@juliusmarminge juliusmarminge added takeover:blocked Takeover blocked; reason in the PR body and removed takeover:in-progress A takeover lead is working on this PR labels Nov 13, 2026
@juliusmarminge

Copy link
Copy Markdown
Member

Thanks for this. Main has the change since #37091.

Compared your complete diff with the merged change in WorkspaceRootScreen: main now reserves the same additional 64pt above the portrait Duo sidebar tab bar for Threads, PRs, and Settings lists. Main also lets keyboard clearance absorb that allowance instead of adding redundant space above the keyboard.

Closing as superseded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Fix PR opened by an issue lead; enters the PR loop pr:gate-failed A land gate failed size:XS 0-9 changed lines (additions + deletions). takeover:blocked Takeover blocked; reason in the PR body vouch:trusted Author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Settled list toggle is obscured by bottom navigation on unfolded iPhone Duo in portrait

2 participants