You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix(mobile): the portrait Duo drawer's last rows clear its tab bar - #26140
On an unfolded iPhone Duo in portrait, the sidebar drawer draws its own floating tab bar, but lists in the drawer only reserved the Duo's usual 16pt of bottom clearance. Even scrolled to the bottom, the last Settings row (Archive) stayed behind the tab bar. The Chats and PRs lists use the same clearance. Landscape was fine because the tabs move to the system side rail.
The Duo branch of bottomClearance in WorkspaceRootScreen assumed the column's safe area already covered everything at the bottom. That holds for the search toolbar and keyboard, but not for WorkspaceSidebarTabs, which renders in the portrait drawer exactly when sidebarPicker is true. That case now reserves 80pt, the same value the other iOS sidebar-picker path already uses. Other Duo layouts are unchanged.
Before / after (unfolded iPhone Duo simulator, portrait, Settings drawer scrolled to the bottom):
Before
After
Done with Claude Opus 5.5 in Claude Code (running in T3 Code).
Macroscope's review found this PR approvable — Adds bottom spacing to the iOS Duo sidebar-picker layout so the last drawer rows can clear its tab bar. The change is limited to presentation, with no product-default or persistent-data changes.
No code changes detected at d9f8ac6. Prior analysis still applies.
You can add or adjust custom eligibility rules. Learn more.
Reviewing files that changed from the base of the PR and between d9f8ac6 and c98d180.
You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.
Use the checkbox below for a quick retry:
Trigger review
No actionable comments were generated in the recent review.
Walkthrough
For Duo devices, the workspace root now adds 80 pixels of bottom clearance when the sidebar picker is active and 16 pixels otherwise. The comment clarifies that the column safe area does not hold sidebar tabs.
pingdotgg/t3code#24206: This PR also changes Duo sidebar tab placement and list bottom-clearance calculations.
Suggested reviewers:juliusmarminge
Merge Risk: Minimal · previous review 9cd16
The change increases bottom clearance for the Duo sidebar picker to address the reported obscured rows. No actionable merge-blocking risk is evident in the supplied context.
Pre-merge checks: 4
Check name
Status
Explanation
Title check
The title clearly describes the drawer clearance fix.
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Description check
The description explains the problem and change, links the related issue, and includes before-and-after screenshots from the affected simulator scenario. It does not include an explicit maintainer app…
Full details: Description check
Explanation
The description explains the problem and change, links the related issue, and includes before-and-after screenshots from the affected simulator scenario. It does not include an explicit maintainer approval comment or describe separate test results, but the description is mostly complete.
Finishing Touches
Generate unit tests (beta)
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.
The automated pipeline stopped on this pull request and will not merge it:
the capture step could not show the problem on the base commit, so there is nothing to prove fixed.
On both commits, opened the unfolded Duo app and requested portrait and landscape rotation. The app remained landscape with its side rail. Opened Settings, selected General, and performed five upward sidebar swipes from (180,550) to (180,160). Recorded the interaction and captured Archive fully above the search toolbar. Final still pairs taken more than 500 ms apart were pixel-identical. The requested portrait reproduction could not be executed.
Thanks for this. Main has the change since #37091.
Compared your complete diff with the merged change in WorkspaceRootScreen: main now reserves the same additional 64pt above the portrait Duo sidebar tab bar for Threads, PRs, and Settings lists. Main also lets keyboard clearance absorb that allowance instead of adding redundant space above the keyboard.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugfixFix PR opened by an issue lead; enters the PR looppr:gate-failedA land gate failedsize:XS0-9 changed lines (additions + deletions).takeover:blockedTakeover blocked; reason in the PR bodyvouch:trustedAuthor is trusted by repo permissions or the VOUCHED list.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On an unfolded iPhone Duo in portrait, the sidebar drawer draws its own floating tab bar, but lists in the drawer only reserved the Duo's usual 16pt of bottom clearance. Even scrolled to the bottom, the last Settings row (Archive) stayed behind the tab bar. The Chats and PRs lists use the same clearance. Landscape was fine because the tabs move to the system side rail.
The Duo branch of
bottomClearanceinWorkspaceRootScreenassumed the column's safe area already covered everything at the bottom. That holds for the search toolbar and keyboard, but not forWorkspaceSidebarTabs, which renders in the portrait drawer exactly whensidebarPickeris true. That case now reserves 80pt, the same value the other iOS sidebar-picker path already uses. Other Duo layouts are unchanged.Before / after (unfolded iPhone Duo simulator, portrait, Settings drawer scrolled to the bottom):
Done with Claude Opus 5.5 in Claude Code (running in T3 Code).
🤖 Generated with Claude Code
Fixes #26990