Repository navigation
fix(server): t3_thread_launch refuses models the provider does not advertise #26625
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
c388c92
82001a9
23e3e03
798adaf
4c79d31
6084b62
89b42be
c7ef303
d0ae47b
1917294
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -29,6 +29,7 @@ import { resolveProjectSettings } from "@t3tools/shared/projectSettings"; | |
| import { resolveRuntimeMode } from "../../delegatedTaskModes.ts"; | ||
| import * as McpInvocationContext from "../../McpInvocationContext.ts"; | ||
| import * as McpToolAccess from "../../McpToolAccess.ts"; | ||
| import * as OrchestrationMcp from "../../OrchestratorMcpService.ts"; | ||
| import { newCommandId, readCaller, resolveProjectId, unavailable } from "../../threadAccess.ts"; | ||
| import { ProjectToolkit } from "./tools.ts"; | ||
|
|
||
|
|
@@ -152,6 +153,13 @@ export const layer = McpToolAccess.toLayer(ProjectToolkit, { | |
| }); | ||
| yield* assertProjectWorktree(project.workspaceRoot, input.workspaceStrategy.worktreePath); | ||
| } | ||
| if (!replaying && input.modelSelection !== undefined) { | ||
|
coderabbitai[bot] marked this conversation as resolved.
Resolved
|
||
| const { instanceId, model } = input.modelSelection; | ||
| const providers = yield* (yield* ProviderRegistry.ProviderRegistry).getProviders; | ||
|
coderabbitai[bot] marked this conversation as resolved.
Resolved
|
||
| const provider = providers.find((candidate) => candidate.instanceId === instanceId); | ||
| if (provider !== undefined) | ||
| yield* OrchestrationMcp.requireAdvertisedModel(provider, model); | ||
| } | ||
|
Comment on lines
+156
to
+162
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
| // Reject unresolved base refs before accepting a launch; worktree provisioning happens later. | ||
| const strategy = input.workspaceStrategy; | ||
| if (!replaying && strategy?.type === "worktree") | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟠 High
mcp/OrchestratorMcpService.ts:1381When
target.modelis an accepted alias for the parent's selected model,inheritsOptionsis false anddelegateTaskdrops the parent's options from the child selection.slugcanonicalizes only the requested model, while this comparison uses the rawinheritedSelection.model; canonicalize the inherited model withrequireAdvertisedModelbefore comparing.🚀 Reply "fix it for me" or copy this AI Prompt for your agent: