Repository navigation
fix(opencode): custom models can go back to the default reasoning level #27333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
juliusmarminge
wants to merge
14
commits into
main
Choose a base branch
from
fix/issue-27304
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+176
−46
Open
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
b537944
test(opencode): reproduce #27304, no way back to sending no variant
juliusmarminge 73039a3
fix(opencode): offer a Default reasoning choice that sends no variant
juliusmarminge 1d8a2f1
fix(opencode): show Default when no variant is chosen
juliusmarminge bbc8257
fix(opencode): keep a variant named default distinct from the Default…
juliusmarminge 535fbb4
fix(web): subagent tooltip omits the Default reasoning choice
juliusmarminge 7c20d8b
Merge remote-tracking branch 'origin/main' into fix/issue-27304
juliusmarminge f874561
Merge remote-tracking branch 'origin/main' into fix/issue-27304
juliusmarminge 418286f
fix(opencode): a reported variant outranks the Default choice
juliusmarminge 7016efe
Merge remote-tracking branch 'origin/main' into fix/issue-27304
juliusmarminge c3ef908
test(opencode): cover the Default variant once, at text generation
juliusmarminge 3af878e
Merge remote-tracking branch 'origin/main' into fix/issue-27304
juliusmarminge 6de63a9
fix(mobile): subagent effort omits the Default reasoning choice
juliusmarminge 1795e1e
Merge commit 'f31ce3eeb5f4adbfe7f961403822cf90db05808f' into fix/issu…
juliusmarminge c290ce0
Merge remote-tracking branch 'origin/main' into fix/issue-27304
juliusmarminge File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Script executed:
Repository: pingdotgg/t3code
Length of output: 13718
Script executed:
Repository: pingdotgg/t3code
Length of output: 27341
Script executed:
Repository: pingdotgg/t3code
Length of output: 1927
Cover both default selections in OpenCode 2 text generation.
The existing test passes no
modelSelection.options, so it exercises neithert3:defaultnor literal"default". Its fixture expectssession.createwithoutmodel.variant. Add cases that assert the sentinel omitsmodel.variantand the literal"default"is forwarded.