Repository navigation
fix(opencode): long command turns no longer fail when the command request times out #27677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
5c061d5
157d524
134aea7
be73494
63b2336
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3026,7 +3026,9 @@ export const makeOpenCodeAdapterV2 = Effect.fn("makeOpenCodeAdapterV2")(function | |
| }), | ||
| ).pipe( | ||
| Effect.asVoid, | ||
| // OpenCode answers only when generation ends; once admitted, the event stream owns the outcome. | ||
| Effect.tapError((cause) => | ||
| Deferred.isDoneUnsafe(receipt) || | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Recover request failures after command receipt completion. If the receipt completes and the SDK request then rejects before the admission race settles, Line 2994 skips
|
||
| abortController.signal.aborted || | ||
| turn.finalized || | ||
| turn.admissionGeneration !== generation | ||
|
Comment on lines
3026
to
3034
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This repeats the native-command admission setup immediately above. Could you fold the timeout and terminal assertion into that existing test instead?
Posted via Macroscope — Test Signal