Skip to content

fix(web): dragging a sidebar thread no longer scrolls the list to the bottom #27691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
t3dotgg merged 8 commits into from
Nov 6, 2026
Merged

fix(web): dragging a sidebar thread no longer scrolls the list to the bottom #27691

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
87bab5f
test(web): reproduce sidebar drag jumping to the settled drop hint (#…
juliusmarminge Oct 30, 2026
31834a4
fix(web): dragging a sidebar thread no longer jumps or runs the list …
juliusmarminge Oct 30, 2026
f8bd812
fix(web): follow the settled drop hint from its resting slot
juliusmarminge Oct 30, 2026
b4d1d8c
fix(web): reveal a settled drop hint that is or rests on screen
juliusmarminge Oct 30, 2026
2a5accc
Merge remote-tracking branch 'origin/main' into fix/issue-27669
juliusmarminge Oct 30, 2026
556e47f
Merge remote-tracking branch 'origin/main' into fix/issue-27669
juliusmarminge Nov 3, 2026
deca1bd
Merge remote-tracking branch 'origin/main' into fix/issue-27669
t3dotgg Nov 6, 2026
49babe1
refactor(web): drop settled hint guard now covered by #30346
t3dotgg Nov 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion apps/web/src/components/Sidebar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ import {
DndContext,
useSensor,
useSensors,
type AutoScrollOptions,
type DragEndEvent,
type DragOverEvent,
type DragStartEvent,
Expand Down Expand Up @@ -876,6 +877,9 @@ function checkThreadOperations(

const SIDEBAR_DRAG_DISTANCE = 6;

// dnd-kit's 20% edge zone at full speed runs the list away while the pointer rests near the bottom.
const SIDEBAR_AUTO_SCROLL: AutoScrollOptions = { threshold: { x: 0, y: 0.05 }, acceleration: 3 };

const SIDEBAR_DRAG_LABEL_HEIGHT = 24;

const threadSearchResultId = (index: number) => `sidebar-thread-search-result-${index}`;
Expand Down Expand Up @@ -3280,7 +3284,7 @@ export default function Sidebar({ routeReveal }: { routeReveal: SidebarRouteReve
>
<DndContext
sensors={dndSensors}
autoScroll={!isContextDrag}
autoScroll={isContextDrag ? false : SIDEBAR_AUTO_SCROLL}
collisionDetection={dndCollisionDetection}
modifiers={dndModifiers}
onDragStart={handleThreadDragStart}
Expand Down
Loading