Repository navigation
Conversation
github-actions
Bot
added
vouch:unvouched
|
No actionable comments were generated in the recent review.
 |
| Layer / File(s) | Summary |
|---|---|
Fixture definitions and native request parsing apps/mobile/src/features/showcase/showcaseAgentActivity.ts, apps/mobile/src/features/showcase/nativeShowcaseScene.ts |
Named fixtures cover store, handoff, completion, failure, and individual phases. Native scene requests can include a fixture name, which defaults to store when it is missing or unrecognized. |
Fixture-driven capture and staging apps/mobile/src/features/showcase/ShowcaseCaptureCoordinator.tsx, apps/mobile/src/features/showcase/stageShowcaseAgentActivity.ts, apps/mobile/src/features/showcase/stageShowcaseAgentActivity.test.ts, apps/mobile/src/features/showcase/showcaseCaptureModel.ts, apps/mobile/src/features/showcase/showcaseCaptureModel.test.ts, scripts/mobile-showcase-environment.ts |
Capture builds activity rows from the selected fixture and passes a cancellation check to staging. Staging checks for cancellation and supplies a stale date when a row is stale. Thread routes remain in the agent-activity scene, and the showcase environment adds two settled thread records. |
Widget phase status and row selection apps/mobile/src/widgets/AgentActivity.tsx |
Phase signals determine marks, status, ordering, counts, summaries, accessibility descriptions, and the selected deep link. Unknown phases resolve to stale. |
Widget layouts and behavior tests apps/mobile/src/widgets/AgentActivity.tsx, apps/mobile/src/widgets/AgentActivity.test.ts |
Widget layouts display a hero row, additional rows, summaries, and hidden-thread counts. Tests cover sorting, stale and finished states, marks, counts, and accessibility. |
Estimated code review effort: 4 (Complex) | ~45 minutes
Change: Feature
Sequence Diagram(s)
sequenceDiagram
participant NativeShowcaseScene
participant ShowcaseCaptureCoordinator
participant buildShowcaseAgentActivity
participant stageShowcaseAgentActivity
participant startAgentLiveActivity
ShowcaseCaptureCoordinator->>NativeShowcaseScene: Read scene and fixture selection
ShowcaseCaptureCoordinator->>buildShowcaseAgentActivity: Build activity rows from the selected fixture
ShowcaseCaptureCoordinator->>stageShowcaseAgentActivity: Stage activity with a cancellation check
stageShowcaseAgentActivity->>startAgentLiveActivity: Start activity with an optional stale date
Suggested reviewers: juliusmarminge, maria-rcks, t3dotgg
Merge Risk: 
f7931
-
The reviewed changes are mergeable after normal checks; no demonstrated issue remains that requires a fix before merge.
Pre-merge checks: 
-
Check name Status Explanation Title check The title "feat(mobile): see an all-done summary when every agent finishes" matches the main change. The PR replaces the Live Activity presentation with a summary shown when no agents are in flight. T… Description check The description follows the Problem, Change, Scope and approval, and Verification structure of the template. It states the problem and the change clearly. It names the approval dependency: it says it … Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request. Full details: Title check
-
Explanation
The title "feat(mobile): see an all-done summary when every agent finishes" matches the main change. The PR replaces the Live Activity presentation with a summary shown when no agents are in flight. The changeset also adds showcase fixtures and a phase-ranked thread summary in AgentActivity.tsx, which the title covers as part of the same feature. The title is a single, specific conventional-commit sentence.
Full details: Description check
-
Explanation
The description follows the Problem, Change, Scope and approval, and Verification structure of the template. It states the problem and the change clearly. It names the approval dependency: it says it is stacked on
#28233and that maintainer approval is pending, and it links the proposed follow-up in#28232. Verification lists the focused test command, the test count, and the typecheck, lint, and format results. It also gives before/after screenshots and recordings, and lists what it did not check. The description does not state a linked triaged bug issue or an approval comment, so the Scope and approval section is incomplete under the template. The template says a PR without maintainer approval needs a linked issue or discussion. The description also acknowledges approval is pending, so the gap is real but does not make the description largely incomplete.Resolution
Consider linking the triaged issue or the discussion that records maintainer approval of direction and scope, with the approval comment. Note that approval is still pending. The description already names the stacked dependency on
#28233and the follow-up in#28232.
-
Finishing Touches
-
Generate unit tests (beta)
-
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
f3b7ba2 to
f79315b
Compare
|
Note 🤖 GPT-6.1 Terra [1m] responding on behalf of Theo Closing because there is no prior maintainer approval for changing the Dynamic Island summary and spoken thread list. Obtain agreement on that scope in Ideas before requesting reconsideration under the contribution policy. #3768 AgentActivity.tsx |
Problem
When every agent finishes, the Live Activity looks the same as when work is in progress. Nothing says you're done, and the Island still shows "Failed" text.
Change
When nothing is in flight, the Live Activity becomes a summary.
Scope and approval
Stacked on #28233; please review the last commit. Proposed as a follow-up in #28232. Maintainer approval is pending. One widget file plus tests and showcase fixtures (
agent-activity:all-done,agent-activity:done-with-failure).Verification
(cd apps/mobile && vp test run --project unit src/widgets src/features/showcase src/features/agent-awareness): 54 passed. Each new test fails when its behavior is removed.vp run typecheck,vp lintandvp fmt --checkpass.iOS 27 Simulator, iPhone 17 Pro. The Island shots are frames from device recordings. "Lock Screen" is the pulled-down cover sheet.
Working, then one fails: the compact
›_becomes the octagon, the Island expands to the summary, and tapping the card opens the failed thread.Videos: working → failure · all done
Not checked:
Claude Opus 5.5 via Claude Code, run from T3 Code.