Skip to content

fix(web): pull request state badge matches the redesign's status chips #29182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maria-rcks merged 1 commit into from
Nov 2, 2026
Merged

fix(web): pull request state badge matches the redesign's status chips #29182

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 10 additions & 9 deletions apps/web/src/components/pullRequest/PullRequestDetailCrumbs.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import type { MouseEvent as ReactMouseEvent, ReactNode } from "react";
import { resolvePullRequestState } from "./pullRequestPresentation";
import { cn } from "~/lib/utils";
import { readLocalApi } from "~/localApi";
import { Badge } from "../ui/badge";
import { Button, InlineButton } from "../ui/button";
import { Tooltip, TooltipPopup, TooltipTrigger } from "../ui/tooltip";
import { openOnHostLabel, showPullRequestLinkContextMenu } from "./pullRequestLinkContextMenu";
Expand Down Expand Up @@ -127,19 +128,19 @@ export function PullRequestDetailCrumbs({
focusable
/>
{detail.state !== "open" || detail.isDraft ? (
<span
className={cn(
"inline-flex h-5 shrink-0 items-center gap-1 rounded-md border px-1.75 text-caption",
<Badge
size="status"
variant={
detail.state === "merged"
? "border-merged-foreground/25 bg-merged-tint text-merged-foreground"
? "merged"
: detail.state === "closed"
? "border-error-foreground/25 bg-error-tint text-error-foreground"
: "border-border bg-badge-neutral text-muted-foreground",
)}
? "error"
: "secondary"
}
>
<state.Icon aria-hidden className="size-[11px]" />
<state.Icon aria-hidden />
{state.label}
</span>
</Badge>
) : null}
{children}
</>
Expand Down
Loading