fix(web): the sidebar shortcut honors terminal and preview focus conditions

apps/web/src/components/AppSidebarLayout.browser.test.tsx

@@ -0,0 +1,42 @@
+import { page, userEvent } from "vite-plus/test/browser";
+import { describe, expect, it, vi } from "vite-plus/test";
+
+import { render } from "../../test/render";
+
+vi.mock(import("../state/server"), async (original) => {
+  const actual = await original();
+  const { Atom } = await import("effect/reactivity");
+  const { compileResolvedKeybindingsConfig } = await import("@t3tools/shared/keybindings");
+  const keybindings = compileResolvedKeybindingsConfig([
+    { key: "mod+b", command: "sidebar.toggle", when: "!terminalFocus" },
+  ]);
+  return { ...actual, primaryServerKeybindingsAtom: Atom.make(keybindings) };
+});
+// The thread list needs live environments; the shortcut lives in the shell around it.
+vi.mock(import("./Sidebar"), () => ({ default: (() => null) as never }));
+
+import { AppSidebarLayout } from "./AppSidebarLayout";
+
+describe("sidebar toggle shortcut", () => {
+  it("leaves the key to a focused terminal when its rule excludes terminalFocus", async () => {
+    await page.viewport(1280, 800);
+    using _platform = vi.spyOn(navigator, "platform", "get").mockReturnValue("Linux x86_64");
+    await using screen = await render(
+      <AppSidebarLayout>
+        <div data-terminal-owner="drawer">
+          <textarea aria-label="Terminal input" />
+        </div>
+        <button type="button">Outside</button>
+      </AppSidebarLayout>,
+    );
+    const wrapper = screen.container.querySelector('[data-slot="sidebar-wrapper"]')!;
+
+    await userEvent.click(screen.getByRole("textbox", { name: "Terminal input" }));
+    await userEvent.keyboard("{Control>}b{/Control}");
+    expect(wrapper.getAttribute("data-sidebar-state")).toBe("expanded");
+
+    await userEvent.click(screen.getByRole("button", { name: "Outside" }));
+    await userEvent.keyboard("{Control>}b{/Control}");
+    await vi.waitFor(() => expect(wrapper.getAttribute("data-sidebar-state")).toBe("collapsed"));
+  });
+});

apps/web/src/components/AppSidebarLayout.tsx

@@ -347,11 +347,15 @@ function SidebarControl({ showSidebar }: { readonly showSidebar: boolean }) {
         // the toggle stays available everywhere else.
         return;
       }
-      if (
-        resolveShortcutCommand(event, keybindings, { context: { usagePageOpen } }) !==
-        "sidebar.toggle"
-      )
-        return;
+      const command = resolveShortcutCommand(event, keybindings, {
+        context: {
+          terminalFocus: isTerminalFocused(),
+          previewFocus: isPreviewFocused(),
+          ...readRoutePanelsOpen(router),
+          usagePageOpen,
+        },
+      });
+      if (command !== "sidebar.toggle") return;
 
       event.preventDefault();
       event.stopPropagation();
@@ -366,7 +370,7 @@ function SidebarControl({ showSidebar }: { readonly showSidebar: boolean }) {
       window.removeEventListener("keydown", onKeyDown, true);
       unsubscribe?.();
     };
-  }, [keybindings, showSidebar, toggleSidebar, usagePageOpen]);
+  }, [keybindings, router, showSidebar, toggleSidebar, usagePageOpen]);
 
   // The control lives as long as the shell, so it carries the shell's commands. Created
   // once so re-renders never re-register them.