Repository navigation
Conversation
… opens Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — Updates mobile hardware-keyboard shortcuts when screens register their commands, without changing the commands or their actions. The limited refresh and test-configuration changes carry no obvious material risk. You can add or adjust custom eligibility rules. Learn more. |
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
Preserve the registration-version fix and adapt the test mocks to the current workspace modules. Co-Authored-By: GPT-6.1 Sol <noreply@openai.com>
Dismissing prior approval to re-evaluate 5070172
Hardware-keyboard shortcuts registered by a newly opened screen were missing from the native enabled-command list until navigation changed. React Compiler dropped an unread
registrationVersionmemo dependency, so the provider missed registrations made after its first render.Read the version through
registeredCommands(registrationVersion)so the compiled memo invalidates when the registry changes. This preserves the existing native iOS and Android dispatch paths. The integration adapts the regression test's two workspace mocks to main'slayout/workspacepaths; its assertion is unchanged.Verification
Integrated with main cc97303, using Node 26.12.1 in Linux Boat:
focusSearchis absent. The candidate passes.check:changedpasses format, lint, knip, two package typechecks, the mounted regression and six selected React Compiler checks. The owning provider is compiled with the release React Compiler in the test'sreactproject.b4c75d141c98fdfe53a2bd73642c255debdbd9cb(task570cc4c7-c5e1-4ae8-83e6-58e6eb2e7bcd). The reviewer inspected supplied logs and did not rerun tests.No fresh iPad or Android hardware-keyboard pass was performed. Hosted CI must run on the pushed merge commit; older green checks are historical.
Original implementation: Claude Opus 5.5 in Claude Code, with the previously recorded GPT-6.1 Sol review. Current-main test adaptation and verification: GPT-6.1 Sol in Codex through T3 Code, independently reviewed by Claude Opus 5.5.