Skip to content

fix(web): editing a scheduled task shows its saved time when the hour has one digit #29851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maria-rcks merged 2 commits into from
Nov 9, 2026
+12 −1
Merged

fix(web): editing a scheduled task shows its saved time when the hour has one digit #29851

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0386632
fix(web): editing a scheduled task shows its saved time when the hour…
saphid Nov 3, 2026
6cd307b
Merge remote-tracking branch 'upstream/main' into fix/scheduled-task-…
github-actions[bot] Nov 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions apps/web/src/components/settings/scheduledTasksSettings.logic.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,6 +172,16 @@ describe("editing scheduled task branch settings", () => {
});
});

describe("fixed-time scheduled tasks", () => {
it("pads a stored single-digit hour so the time input shows it", () => {
const draft = taskToDraft({
...legacyTask,
schedule: { type: "fixed_time", timeOfDay: "9:05" },
});
expect(draft.timeOfDay).toBe("09:05");
});
});

describe("scheduled task destination", () => {
it("unbinding leaves the shared checkout for a new worktree from the remote", () => {
const rootBound = taskToDraft({
Expand Down
3 changes: 2 additions & 1 deletion apps/web/src/components/settings/scheduledTasksSettings.logic.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,7 +253,8 @@ export function taskToDraft(task: ScheduledTask): DraftState {
scheduleMode: schedule.type === "fixed_time" ? "fixed" : schedule.type,
intervalMinutes:
schedule.type === "interval" ? String(Math.max(1, schedule.everyMs / 60_000)) : "15",
timeOfDay: schedule.type === "fixed_time" ? schedule.timeOfDay : "09:00",
// A time input shows nothing for an unpadded hour such as 9:05, which agents may save.
timeOfDay: schedule.type === "fixed_time" ? schedule.timeOfDay.padStart(5, "0") : "09:00",
runAt: schedule.type === "once" ? toDateTimeLocalValue(new Date(schedule.runAt)) : "",
savedRunAt: schedule.type === "once" ? schedule.runAt : "",
weekdays,
Expand Down
Loading