[saphid]

Problem

On the Pull Requests page, the project filter on web, desktop and mobile lists pinned projects wherever their recent activity places them. Every other project menu puts pinned projects at the top. That includes the sidebar's project menu, the command palette, the new-thread project picker, and mobile's new-task picker and thread list filters. A pinned project can therefore sit mid-list in the PR filter while it is first everywhere else.

To reproduce: pin a project that hasn't had recent activity, open Pull Requests, and open the project filter. The pinned project is not first.

Change

#19180 made the PR filter follow the sidebar order through sortProjectsByGroupOrder. Pinned and archived projects came later (#26154). That change gave the other menus pickableProjectGroups (pinned first, archived hidden), but sortProjectsByGroupOrder never got it.

sortProjectsByGroupOrder now ranks groups through pickableProjectGroups. Its only callers are the two PR filters, web and mobile. Pinned projects come first. Archived projects stay in the filter but move to the end, the same as projects in no group. The mobile order atom now carries pinned and archived, and its equality check compares them, so pinning or unpinning re-sorts the menu.

Scope and approval

This is a very small, focused fix for an obvious bug, so there's no prior issue. One shared helper skipped the pinned-first step its sibling menus apply. The change is 8 lines in the helper and 10 in the mobile atom, plus one test case.

Overlap search: I checked the local PR index and GitHub search for PR filter, pinned project and sortProjectsByGroupOrder. The only related PR is #19180 (merged), which added this ordering. #29846 fixes manual order in the new-thread picker, a different surface. I found no duplicate.

Verification

• Extended describe("sortProjectsByGroupOrder") in packages/client-runtime/src/state/projectGrouping.test.ts with a pinned group, an open group, an archived group and an ungrouped project.
• Red on main: expected [ 'archived', 'recent', 'pinned', 'unlisted' ] to deeply equal [ 'pinned', 'recent', 'archived', 'unlisted' ].
• Green: vp test run src/state/projectGrouping.test.ts, 23/23. Reran after rebasing onto current main: 23/23.
• vp run check:changed: format, lint, knip, typecheck (7 packages), tests and react compiler all pass.
• Not checked: no screenshots or real-client run. The change only affects list order, and the unit test checks that order directly.

Reviewed with sol-loop: 1 round with GPT-6.1 Sol on high. Sol verdict: approved.

Created with Claude Opus 5.5 in Claude Code (T3 Code).

🤖 Generated with Claude Code

[macroscopeapp]

Approvability

Verdict: Approved at eb3b743

Macroscope's review found this PR approvable — Web and mobile pull-request project filters now place pinned projects first and refresh their ordering when pin/archive state changes. The change is limited to menu ordering and preserves existing filter selections.

^{You can add or adjust custom eligibility rules. Learn more.}

[coderabbitai]

No actionable comments were generated in the recent review.

Walkthrough

Project order now includes each group’s pinned and archived flags. Project sorting uses those flags to rank projects. Tests cover cross-environment project IDs and ordering for pinned, unarchived, archived, and unlisted projects.

Changes: Project group ordering

Layer / File(s)	Summary
Group flags and project sorting apps/mobile/src/features/pull-requests/PullRequestListFilters.tsx, packages/client-runtime/src/state/projectGrouping.ts, packages/client-runtime/src/state/projectGrouping.test.ts	The sidebar project order includes each group’s pinned and archived flags, and equality checks compare them. Sorting excludes archived groups and ranks pinned groups before unpinned groups. Tests cover cross-environment project IDs and project ordering.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Suggested reviewers: t3dotgg, maria-rcks

Merge Risk: Minimal · up to 08e8f

The Pull Requests project filter now lists pinned projects first and keeps archived projects selectable at the end. This is a small, reversible ordering change with unit tests and a manual web check. No merge-blocking risk remains.

Pre-merge checks: 4

Check name	Status	Explanation
Title check		The title names the actual change: the pull request project filter now lists pinned projects first. It matches the raw summary, which says sortProjectsByGroupOrder now ranks groups through pickablePro…
Description check		The description follows the template. It has Problem, Change, Scope, and Verification sections, and each one has real content. Problem states the bug and gives reproduction steps. Change explains the …
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Title check

Explanation

The title names the actual change: the pull request project filter now lists pinned projects first. It matches the raw summary, which says sortProjectsByGroupOrder now ranks groups through pickableProjectGroups with pinned first, and the PR objectives, which describe the same ordering. The title follows the conventional commit style the template asks for. It is 72 characters, which is within a typical limit.

Full details: Description check

Explanation

The description follows the template. It has Problem, Change, Scope, and Verification sections, and each one has real content. Problem states the bug and gives reproduction steps. Change explains the fix through sortProjectsByGroupOrder and pickableProjectGroups. Scope explains why no issue is linked and gives an overlap search. Verification lists the focused test, the red-then-green result, and the full check run, and it says what was not checked (screenshots and a real client run). The template asks for before/after screenshots for UI changes. The author says none were taken, and the description states this openly. The closing line asks for the model and harness, and the author names Claude Opus 5.5 in Claude Code. The template's note on assets and the request for a linked issue are the main gaps, but the description is mostly complete.

Finishing Touches

Generate unit tests (beta)

• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Usage-based review receipt

• Mode: Continue automatically
• Reviewed files: 2
• Charged: $0.50
• View usage details

Note

This review was completed with usage-based billing: files reviewed beyond your plan's included limits are billed at $0.25/file. View usage-based billing.

Recent review info

Run configuration

• Source mode: Auto
• Repository: pingdotgg/t3code
• Branch: main
• File: .coderabbit.config.ts
• Commit: 1fcb245
• Layers: Repository TS config
• Review profile: CHILL
• Plan: Advanced
• Run ID: f0914bcf-9e62-4c26-90c8-43010bf9fb07

Commits

Reviewing files that changed from the base of the PR and between eb3b743 and 08e8f96.

Files selected for processing: 2

• packages/client-runtime/src/state/projectGrouping.test.ts
• packages/client-runtime/src/state/projectGrouping.ts

Limit details: You’ve used all 10 included reviews currently available.

[maria-rcks]

Note

Written by gpt-6.1-sol on behalf of Maria

Verified in a real dev environment

Verified unchanged head eb3b743d50f4f60762e088610fd25657044ad7a6 on Linux with the real dev web app, repository Playwright and /usr/bin/google-chrome.

Created three real Git projects through Add project, started threads, and completed Codex gpt-6.1-sol turns through the composer. No mocks, fixtures or demo data. Reproduced on github/main (61c3794c32), stopped that dev server, then ran the exact PR head with an isolated copy of the same app-created data.

• Main: Filters > Project listed archived-project, newer-active, then older-pinned, despite the last project being pinned.
• PR: older-pinned is first and archived-project is last.
• Unpinning moves the older project back below the active projects; repinning restores it first without reloading. The order persists after reload.
• Selecting a project updates the URL and checked item; All projects clears the selection. The archived project remains selectable here. The sidebar picker still puts the pinned project first and hides the archived project.
• A fresh Codex turn on the PR head returned PR_HEAD_VERIFIED through the running server and client.

Blacksmith transcript:

vp test run src/state/projectGrouping.test.ts: 23 passed
vp run check:changed c0ec87a55bbffa437673f037d7b4ca68c6a300f1:
  pass format
  pass lint
  pass knip (both passes)
  pass typecheck (7 packages)
  pass test (23 tests)
  pass react compiler (changed mobile file)

The explicit base was needed because the worker starts with shallow snapshot history; fetched PR history on the worker before the successful run. Reported CI: 31 successful, 0 failing, 0 pending. No code changes or pushes were needed.

Before, main:

After, PR:

Selection and reset recording:

The uploaded recording plays and seeks in Chrome. GitHub does not render this external MP4 inline.

Real provider response:

Not verified

Native iOS/Android menus and Electron desktop were not exercised on this Linux browser run. Remote/relay and multi-environment ordering were not exercised. The created repositories are local and unpublished, so project-specific filtering of populated remote PR results was not verified; selection, reset, ordering and persistence were exercised. The screenshots use the same created projects and search; restarting the server added a default server draft and changed relative timestamps.

[juliusmarminge]

Evidence

Both real-app scenarios reproduce the bug on base and show it fixed on head. Fresh synthetic state on each commit; Chromium at 1280×800 and native iOS on an iPhone 18 Pro, both light theme.

Steps: Create alpha-old, beta-new, and gamma-archived. Run earlier Replay activity in alpha, pin alpha, then run newer beta activity. Archive gamma through the project API. Capture the sidebar and PR Project filter. Unpin alpha, add newer beta activity, and recapture. Repin alpha, add newer beta activity, and recapture. On iOS, change pin flags through the project API while keeping the PR screen mounted.

On base, the initial PR filter lists gamma → beta → alpha; after unpin/repin it lists beta → gamma → alpha. On head it lists alpha → beta → gamma, then beta → alpha → gamma after unpinning, then alpha → beta → gamma after repinning. Archived gamma remains visible at the end.

Capture	Before 1fcb24518a	After 08e8f960db
Web sidebar, newer beta activity visible
Web pinned and archived
Web after unpin
Web after repin
iOS pinned and archived
iOS after unpin
iOS after repin
Web interaction recording	Before video	After video
iOS interaction recording	Before video	After video

Web scenario, iOS scenario, iOS project API seed/update helper. Recordings omit pairing/setup frames. All listed stills and recordings were visually inspected.

Not shown:

• Electron desktop shell and Android were not separately launched; captures cover web and the changed mobile component on native iOS.