Repository navigation
feat(usage): thread details card shows the hub account each thread was routed to #29978
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
EhsanulHaqueSiam
wants to merge
23
commits into
pingdotgg:main
Choose a base branch
from
EhsanulHaqueSiam:feat/thread-hub-session-account
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,072
−41
Open
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
6187366
fix(web): show a proxied instance's limits from its usage hub
PedroNavHur 21afe7f
fix(web): count hub accounts by login for the thread limits fallback
PedroNavHur ad142b9
docs: note the thread details card can show a hub's account
PedroNavHur c7c2c53
fix(web): keep workspaces apart when counting hub accounts
PedroNavHur c5aefff
docs: say the hub fallback counts accounts across hubs
PedroNavHur 793c1b5
fix(web): count unreadable hub accounts before the limits fallback
PedroNavHur fda987b
fix(web): key hub accounts with the shared account resolver
PedroNavHur f6d9b34
fix(web): skip the hub limits fallback while a hub cannot be read
PedroNavHur 0bdb4f1
fix(web): match workspaces when borrowing hub limits
PedroNavHur 4613d07
test(web): drop the null-instance case from the thread limits tests
PedroNavHur e2ae0d6
fix(web): skip a hub account whose workspace is ambiguous
PedroNavHur 09fc955
refactor(web): pull hub account dedup into its own helper
PedroNavHur 0648914
test(web): cover hub accounts keyed by credential fingerprint
PedroNavHur 3c6108c
merge: sync main into thread limits fix
maria-rcks 673fcf8
merge: sync main into thread limits fix
EhsanulHaqueSiam ef020bf
feat(usage): thread details card reads the hub account a thread was r…
EhsanulHaqueSiam 622e5c4
fix(usage): the hub account a thread was routed to wins over a signed…
EhsanulHaqueSiam 360f7d0
fix(usage): keep thread account routes when nobody is watching or a h…
EhsanulHaqueSiam db1b534
fix(usage): a queue read that lands after Thread accounts is switched…
EhsanulHaqueSiam dbff7df
merge: sync main into thread hub session accounts
maria-rcks ff264dd
merge: sync main into thread hub session accounts
EhsanulHaqueSiam 1e3828c
test(usage): give the routed-session secret stubs the label main now …
EhsanulHaqueSiam cbc7d9c
fix(web): thread accounts setting builds and lints on current main
EhsanulHaqueSiam File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wait for the late queue read to finish.
This one-second clock advance does not prove that the queue request started or that its result reached
publish. The final assertion also passes when no queue request ran. Signal request start and await an observable post-read milestone before asserting that the late route was discarded. As per coding guidelines, “Never wait on sleeps or polling.” As per path instructions, “await a meaningful milestone such as a Deferred or persisted event, or drain the effect worker.”Sources: Coding guidelines, Path instructions