Skip to content

fix(web): dragging a sidebar thread no longer scrolls the list out from under the pointer #30346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
juliusmarminge merged 2 commits into from
Nov 5, 2026
Merged

fix(web): dragging a sidebar thread no longer scrolls the list out from under the pointer #30346

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e4df6b9
fix(web): dragging a sidebar thread no longer scrolls the list out fr…
juliusmarminge Nov 3, 2026
d65efb3
fix(web): holding a dragged thread near the sidebar bottom no longer …
juliusmarminge Nov 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions apps/web/src/components/Sidebar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3299,6 +3299,10 @@ export default function Sidebar({ routeReveal }: { routeReveal: SidebarRouteReve
"relative flex flex-col gap-px",
sidebarListItems.length > 0 && "flex-1",
actionSweep !== null && "**:pointer-events-none",
// Projected rows (two boundary labels, two hints) extend the scroll range; a range that
// shrinks as the target changes clamps scrollTop and flips the target under a still pointer.
dragState !== null &&
"after:pointer-events-none after:absolute after:inset-x-0 after:-bottom-30 after:h-px after:content-['']",
)}
>
{(() => {
Expand Down
5 changes: 4 additions & 1 deletion apps/web/src/components/sidebar/SidebarListMarkers.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,10 @@ export function SidebarSectionPlaceholder(props: {
marker={props.marker}
data-testid={`sidebar-${props.marker}`}
className="relative mx-0.5 -mb-px h-0"
revealOverflow={props.marker === "settled-placeholder" && props.showHint}
// Revealing on every drag scrolls the list out from under the pointer.
revealOverflow={
props.marker === "settled-placeholder" && props.showHint && props.isDropTarget
}
>
{props.showHint ? (
<div
Expand Down
Loading