Repository navigation
fix(server): only offer desktop app updates the desktop can install #30804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+78
−7
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
a7a81d9
test(server): reproduce #30784 desktop update capability advertised w…
juliusmarminge 8ccb2b0
fix(server): advertise desktop app updates only when the desktop can …
juliusmarminge 2c6d690
Merge origin/main into fix/issue-30784
juliusmarminge e589e4f
test: trim desktop update capability tests to the regression
juliusmarminge 7d4244f
Merge remote-tracking branch 'origin/main' into fix/issue-30784
juliusmarminge 90ce59c
Merge remote-tracking branch 'origin/main' into fix/issue-30784
juliusmarminge e53b3e0
Merge remote-tracking branch 'origin/main' into fix/issue-30784
juliusmarminge 4415a79
Merge branch 'main' into fix/issue-30784
juliusmarminge ec0c2de
Merge branch 'main' into fix/issue-30784
juliusmarminge File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Script executed:
rg -n -C 5 'desktopAppUpdate|desktopAppChannelSwitch|channelBlockedByPolicy' apps packagesRepository: pingdotgg/t3code
Length of output: 41918
Script executed:
Repository: pingdotgg/t3code
Length of output: 16883
Script executed:
Repository: pingdotgg/t3code
Length of output: 43506
Script executed:
Repository: pingdotgg/t3code
Length of output: 22053
Script executed:
Repository: pingdotgg/t3code
Length of output: 15549
Distinguish current-channel updates from channel switches.
If policy blocks nightly, a newer nightly client can offer a regular update that fails because the desktop updater is disabled. Hide that action while keeping the switch to stable available.