Repository navigation
Conversation
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — Removes AppImage mount entries from inherited, cached, and discovered PATH values before they reach desktop subprocesses or are cached again. The cleanup is limited to Linux AppImage launches and leaves unrelated paths and other runtime modes unchanged. You can add or adjust custom eligibility rules. Learn more. |
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the
Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
|
Note Written by Verified in a real dev environmentverified head used launched electron with
Not verifieda packaged appimage executable and real fuse mount lifecycle were not exercised. this ran the actual electron desktop startup with appimage launch variables and deliberately stale inherited paths. macos, windows, native mobile clients, and other providers were not exercised. no performance claim. current merge verificationmerged the duplicate linux subprocess finding is already addressed by the existing darwin-only case; the review thread is resolved. two independent read-only reviews found no correctness blockers on the merged head. blacksmith verification on this head passed |
589c763 to
209d4df
Compare
209d4df to
4989fe2
Compare


Linux AppImage launches can restore obsolete
/tmp/.mount_T3-*directories from a version-1 shell environment cache and pass them into login-shell discovery and the desktop-hosted server. A synthetic cached + inherited PATH reproduces this on current main.Remove current APPDIR entries and historical T3 mount entries at the desktop cache/discovery boundary: before inherited PATH is used, before cache replay, and before discovered PATH is published or persisted. Keep unrelated paths, mise metadata, and the existing PATH merge policy. The scrubber preserves existing empty entries and deletes PATH when removing its entries leaves none. Non-AppImage and non-Linux launches retain their behavior.
This is a small, focused obvious-bug fix under the contribution exception, with no new product behavior or settings. No upstream maintainer approval is claimed. #16679 and #30688 address current-mount runtime environments at provider spawn; #29672 addresses mount lifetime. This PR only fixes historical PATH contamination in desktop cache/discovery.
Proof on Linux:
vp test run src/shell/DesktopShellEnvironment.test.ts -t 'keeps AppImage mounts|does not wait for discovery when the cache is missing'fromapps/desktopgives 4 failed, 3 passed, 21 skipped. Failures show stale cache/inherited entries survive and a mount-only PATH remains installed.vp run check:changedpasses format, lint, both Knip passes, desktop/scripts typechecks, and 28 tests. Commit hooks also pass.Limits: synthetic AppImage environment on Linux; no packaged AppImage/GUI or native ARM64/macOS/Windows run. Historical matching covers the observed
/tmp/.mount_T3-*naming, not renamed AppImages or custom TMPDIR mounts; another AppImage sharing that filename prefix is indistinguishable. Current APPDIR is handled regardless of its location. No filesystem mount removal or performance claim.Reviewed with review-loop: 1 round with Claude Opus 5.5 on high. Reviewer verdict: approved. No blocker or should findings; known naming limitation documented. Removed the redundant Linux subprocess row following Macroscope Test Signal feedback; implementation unchanged.
Created with GPT-6.1 Sol in the Codex harness.