Repository navigation
fix(shared): hide web-search citation markers in assistant messages #31053
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
juliusmarminge
wants to merge
11
commits into
main
Choose a base branch
from
fix/issue-30979
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+139
−14
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
0932012
test(shared): reproduce #30979 web citation markers shown literally
juliusmarminge 2ffb1f3
fix(shared): hide web citation markers in assistant messages
juliusmarminge 4a6ce83
fix(shared): keep web citation markers out of bare-URL links
juliusmarminge cec6f2a
fix: hide web citation markers in follow-up labels and mobile copy
juliusmarminge 1c6ec66
fix(shared): keep code in follow-up labels when hiding web citations
juliusmarminge 0c96fe2
perf(shared): keep the streamed href scan off the citation-marker parse
juliusmarminge 6ab7d10
Merge remote-tracking branch 'origin/main' into fix/issue-30979
juliusmarminge dedf690
Merge remote-tracking branch 'origin/main' into fix/issue-30979
juliusmarminge 322ee61
fix(shared): keep word separators and clean link destinations when hi…
juliusmarminge 639a6ca
fix(shared): keep the space before a citation marker that precedes Ma…
juliusmarminge 7c74436
fix(shared): keep emphasis and file citations intact when hiding web …
juliusmarminge File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.