Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions apps/web/src/components/chat/ThreadDetailsPrRow.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,7 @@ import {
AlertDialogTitle,
} from "../ui/alert-dialog";
import { Button } from "../ui/button";
import { Spinner } from "../ui/spinner";
import { toastManager } from "../ui/toast";
import { Tooltip, TooltipPopup, TooltipTrigger } from "../ui/tooltip";
import {
Expand Down Expand Up @@ -371,10 +372,15 @@ export function ThreadDetailsPrRow({
: rowAction === "fix"
? {
label: "Fix",
pendingLabel: "Preparing...",
pendingLabel: "Fix",
pending: handoff === "findings",
destructive: true,
suffix: newThreadSuffix,
suffix:
handoff === "findings" ? (
<Spinner size="xs" aria-label="Preparing fix" />
) : (
newThreadSuffix
),
tooltip:
composerTarget === undefined
? "Fix the failing checks in a new thread"
Expand Down Expand Up @@ -478,7 +484,7 @@ export function ThreadDetailsPrRow({
checksState={checksRollup}
checks={detail.checks}
variant="count"
render={<ThreadDetailsControl part="meta" />}
render={<ThreadDetailsControl part="meta" className="min-w-0 shrink" />}
/>
) : null}
{watchControl("icon")}
Expand Down
10 changes: 7 additions & 3 deletions apps/web/src/components/pullRequest/PullRequestChecksPopover.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -182,11 +182,15 @@ export function PullRequestChecksPopover({
{variant === "count" ? (
<>
{checks !== undefined && incompleteCount > 0 ? (
<span className="tabular-nums">
{checks.length - incompleteCount}/{checks.length} checks
// Clip the second line so "checks" disappears whole when the count must shrink.
<span className="h-lh min-w-0 overflow-hidden text-left whitespace-normal tabular-nums">
<span className="whitespace-nowrap">
{checks.length - incompleteCount}/{checks.length}
</span>{" "}
checks
</span>
) : failedCount > 0 ? (
<span className="tabular-nums">{failedCount} failed</span>
<span className="min-w-0 truncate tabular-nums">{failedCount} failed</span>
) : null}
</>
) : null}
Expand Down
Loading