Skip to content

fix(web): preserve settings breadcrumb labels and align layout actions #31598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maria-rcks merged 3 commits into from
Nov 10, 2026
+5 −7
Merged

fix(web): preserve settings breadcrumb labels and align layout actions #31598

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5d8ded5
fix(web): preserve full section names in settings breadcrumbs
flamboh Nov 5, 2026
a463fd4
fix(web): match layout header actions to standard settings actions
flamboh Nov 5, 2026
caab5e5
fix(web): align layout and model-folder row controls
flamboh Nov 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions apps/web/src/components/settings/LayoutSettings.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,11 +265,11 @@ function YourLayoutHeader({
</div>
{/* Ghost buttons hang by their 8px inline inset so the last label ends on the card edge. */}
<div className="-me-2 flex shrink-0 items-center gap-1">
<Button size="xs" variant="ghost-muted" disabled={!canUndo} onClick={onUndo}>
<Button size="standard" variant="ghost-muted" disabled={!canUndo} onClick={onUndo}>
<Undo2Icon aria-hidden />
Undo
</Button>
<Button size="xs" variant="ghost-muted" disabled={!canReset} onClick={onReset}>
<Button size="standard" variant="ghost-muted" disabled={!canReset} onClick={onReset}>
<RotateCcwIcon aria-hidden />
Reset
</Button>
Expand Down Expand Up @@ -336,7 +336,7 @@ function PlacementRow<Value extends string>({
if (option) onChange(option.value);
}}
>
<SelectTrigger size="sm" aria-label={title}>
<SelectTrigger variant="well" size="compact" aria-label={title}>
<SelectValue>
{(current: Value) => {
const option = byValue.get(current);
Expand Down
6 changes: 2 additions & 4 deletions apps/web/src/components/settings/SettingsScopePicker.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,13 +196,11 @@ function ScopePopover({
>
<PopoverTrigger
aria-label={`Settings scope: ${triggerLabel}`}
render={<ContentButton variant="tab" className="-ms-2.5" />}
render={<ContentButton variant="breadcrumb" className="-ms-2.5" />}
>
{trigger}
{projectLabel || environmentLabel ? (
<span className="min-w-0 max-w-48 truncate text-meta text-muted-foreground">
{triggerLabel}
</span>
<span className="min-w-0 truncate text-meta text-muted-foreground">{triggerLabel}</span>
) : null}
</PopoverTrigger>
<PopoverPopup align="start" alignOffset={48} padding="none" initialFocus={searchRef}>
Expand Down
Loading